Migrate dotnet-MsiInstallation.Tests to MSTest.Sdk on MTP#54901
Merged
Evangelink merged 2 commits intoJun 22, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the dotnet-MsiInstallation.Tests VM-based MSI installation test project from xUnit to MSTest.Sdk (Microsoft Testing Platform), aligning it with the repo’s ongoing xUnit → MSTest migration strategy.
Changes:
- Switched test project SDK and references to
MSTest.Sdk+Microsoft.NET.TestFramework.MSTest, and added neededUsingitems for MSTest-based builds. - Converted xUnit attributes to MSTest equivalents (
[Fact]/[Theory]→[TestMethod],[InlineData]→[DataRow],Skip→[Ignore]) and removedITestOutputHelperctor injection. - Replaced xUnit collection-based serialization with MSTest parallelization control via
[DoNotParallelize]on the VM base class.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet-MsiInstallation.Tests/WorkloadSetTestsBase.cs | Updates base test class ctor to MSTest-style (no output helper injection). |
| test/dotnet-MsiInstallation.Tests/WorkloadSetTests2.cs | Converts test class/attributes to MSTest and adds [TestClass]. |
| test/dotnet-MsiInstallation.Tests/WorkloadSetTests.cs | Converts test class/attributes to MSTest, including skip handling via [Ignore]. |
| test/dotnet-MsiInstallation.Tests/VSWorkloadTests.cs | Converts test class/attributes to MSTest and removes output-helper ctor injection. |
| test/dotnet-MsiInstallation.Tests/MsiInstallerTests.cs | Converts test class/attributes to MSTest and removes output-helper ctor injection. |
| test/dotnet-MsiInstallation.Tests/Framework/VMTestBase.cs | Updates VM test base for MSTest, including removing xUnit collection usage. |
| test/dotnet-MsiInstallation.Tests/dotnet-MsiInstallation.Tests.csproj | Switches to MSTest.Sdk, updates test framework reference, and adds MSTest-specific global usings. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 2
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/ba-g unrelated razor test: Exception Message CallStack |
JeremyKuhne
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing xUnit -> MSTest.Sdk (MTP) test migration of the .NET SDK test suite, following the same pattern as the other open migration PRs (builds on the foundation merged in #54845).
Preserves the Windows-only test-app behaviour (non-Windows builds as a plain library via IsTestApplication=false); the [Collection] VM serialization becomes [DoNotParallelize] (inherited by the derived test classes).
Standard transformations: Microsoft.NET.Sdk -> MSTest.Sdk, the TestFramework project reference -> Microsoft.NET.TestFramework.MSTest, [Fact]/[Theory] -> [TestMethod], [InlineData] -> [DataRow], xUnit asserts -> MSTest (including the repo Recommended-mode idiomatic asserts), and ITestOutputHelper constructor injection removed in favour of the base SdkTest Log / TestContext.
Builds clean for the SDK target framework.