release: v2.3.0 "Datum II" — PPU-accuracy capstone + true multi-viewport tool windows

[doublegate]

Cuts v2.3.0 "Datum II", closing the v2.2.6 → v2.3.0 NESdev-remediation line.

Both remaining forum-reported accuracy concerns were investigated under reproduce-before-fixing discipline and turned out to be already correct — so the substance of this release landed elsewhere: tool panels that open as real OS windows, and a frame-pacing defect that had been quietly degrading every session with a debugger panel open.

AccuracyCoin 141/141 (100.00%), nestest 0-diff — now enforced as an exact count rather than a 60% floor.

Tool windows are now real OS windows

v2.2.9's detach affordance only embedded the panel (a single-viewport egui_winit integration can't make show_viewport_immediate produce a window), so the Windows-10 "trapped window" report was never actually resolved. It is now. The new crates/rustynes-frontend/src/detached.rs gives each detached panel a real winit window with its own egui Context/State/Renderer and wgpu Surface, sharing the main device — with no unsafe, unlike eframe's immediate-viewport path (which erases an &ActiveEventLoop lifetime into a 'static thread-local). Each window renders on its own RedrawRequested, where the panel's &mut Nes borrow is freshly re-acquired; a thread-local render target makes the shared dispatch paint exactly one panel per window.

All nine panels that predated the shared helper (CPU, Cartridge Info, Lua Script, BasicBot, Input bindings, TAStudio, Settings, Netplay, RetroAchievements) were converted, so every tool window is detachable. They inherit the main window's theme/zoom/locale and open at the size their docked window actually had.

The frame-pacing fix (stutter / high p99)

Profiling found a root cause predating this work. The overlay-visible render branch held the emulator mutex — in its own comment's words — "until after the present call", and inside render_with_overlay the blocking get_current_texture runs before the egui pass. So every frame with the overlay or any nes-reading panel open, the winit thread owned the lock across a swapchain wait, the whole egui build, the encode and the present, while the emulation thread sat parked on emu.lock() unable to produce. render_shell is split into run_shell_ui (locked) and paint_shell (unlocked GPU work). pace_frames also stopped taking the mutex on every about_to_wait iteration, reading the lock-free EmuControl::has_rom atomic instead.

Maintainer-confirmed: p99 substantially improved, docked and detached.

PPU: −5.13% frame cost, byte-identical

A measure-first campaign (v2.3.0 P1) that began by discarding its own baseline — the first profile ran contended at 39% criterion outliers; re-measured quiet it reported 2%. perf annotate showed tick_sprite_eval_per_dot's own push/ret were the two hottest instructions in its body (pure call overhead across 89,342 calls/frame), and that tick_oam_bus derived values it discarded before its dot-0 early-out.

Workload	before	after	change
nes_run_frame_nestest_fast	3.8987 ms	3.7830 ms	−5.13% (CI −5.60…−4.60, p = 0.00)
nes_run_frame_flowing_palette_fast	2.7314 ms	2.6354 ms	−3.51% (CI −3.93…−3.10, p = 0.00)

Both clear the project's >3% bar on both workloads.

Honesty / provenance

• The ≤ 2 ms frame-cost figure is relabelled a design-phase aspiration, not a gate — it predates the cycle-accurate core. The core is ~3.8 ms (~23% of the NTSC budget) and that's knowingly accepted; the levers were already measured and rejected (emit_pixel elision and the SIMD blitter were both slower). Recorded so nobody optimizes toward it by trading away accuracy.
• TriCNES is no longer called "transistor-level" — it's a cycle-accurate C# emulator with a sub-cycle state machine. The term properly denotes die-derived sims (Visual2C02/phantom2c02), which the repo cites correctly. Fixed in source, NOTICE, README, ADR 0030, and the published v2.0.2 / v2.2.5 release notes.
• GeraNES comments corrected — dangling source paths and a quoted C++ line reworded to state honestly that its source was consulted as a cross-reference for nesdev-documented behavior, no code copied (verified two-sided).
• docs/STATUS.md also corrects a leftover overclaim that credited v2.2.9 with real OS-window detach.

Pre-release gate — all green

cargo fmt --all --check                                    clean
cargo clippy --workspace --all-targets -D warnings         clean
cargo build -p rustynes-core --target thumbv7em-none-eabihf --no-default-features   clean
RUSTDOCFLAGS=-D warnings cargo doc --workspace --no-deps    clean
markdownlint (pinned pre-commit hook)                       clean
cargo deny check licenses                                   ok
cargo audit (675 crate dependencies)                        0 vulnerabilities
cargo test --workspace                        1923 passed / 0 failed / 13 ignored
cargo test --workspace --features test-roms   2227 passed / 0 failed / 20 ignored

Notes for review

• History was rewritten on this branch: the v2.2.9 squash commit's 780-line message was reworked into a structured 65-line one. Backup ref: backup/pre-reword-bcc9c769.
• Merging to main will trigger release-auto.yml to tag and publish v2.3.0 with desktop binaries once main CI is green on the full Windows/macOS matrix (PRs run Linux-only).
• Known limitation: egui can't place a control in a native title bar, so Detach is a top-row control rather than sitting beside the close button.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Released version 2.3.0 “Datum II.”
  • Added native detached tool windows for debugger and utility panels, with resizing, independent refresh, and easy reattachment.
• Performance
  • Improved frame pacing and reduced lock-related stuttering.
  • Optimized PPU processing while preserving identical output.
• Bug Fixes
  • Hardened movie importing and confirmed full AccuracyCoin compatibility at 141/141.
• Documentation
  • Updated release, licensing, provenance, compatibility, and support documentation.

[coderabbitai]

Warning

Review limit reached

@doublegate, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d27090ed-5eec-4331-9dda-24178821f979

📥 Commits

Reviewing files that changed from the base of the PR and between 306410c and 8a66ae4.

📒 Files selected for processing (21)

• .github/release-notes/v2.0.2.md
• .github/release-notes/v2.2.5.md
• .github/release-notes/v2.3.0.md
• AGENTS.md
• CHANGELOG.md
• NOTICE
• README.md
• SUPPORT.md
• VERSION-PLAN.md
• crates/rustynes-frontend/src/app.rs
• crates/rustynes-frontend/src/debugger/cpu_panel.rs
• crates/rustynes-frontend/src/debugger/mod.rs
• crates/rustynes-frontend/src/detached.rs
• crates/rustynes-frontend/src/emu.rs
• crates/rustynes-frontend/src/emu_thread.rs
• crates/rustynes-frontend/src/gfx.rs
• crates/rustynes-ppu/src/ppu.rs
• crates/rustynes-test-harness/tests/accuracycoin.rs
• docs/originality-and-provenance.md
• docs/performance.md
• docs/scheduler.md

📝 Walkthrough

Walkthrough

RustyNES v2.3.0 adds native detached debugger windows, narrows emulator lock scope during rendering, optimizes PPU helpers, enforces exact 141/141 AccuracyCoin validation, and updates release, licensing, provenance, and project documentation.

Changes

v2.3.0 release

Layer / File(s)	Summary
Detached window runtime crates/rustynes-frontend/src/app.rs, crates/rustynes-frontend/src/detached.rs, crates/rustynes-frontend/src/gfx.rs	Native detached windows now support lifecycle reconciliation, event routing, resizing, refresh tiers, independent rendering, and shared GPU resources.
Debugger panel integration crates/rustynes-frontend/src/debugger/*	Debugger panels use shared detached-window state and preserve their existing configuration across native and wasm builds.
Rendering, PPU optimization, and validation crates/rustynes-frontend/src/app.rs, crates/rustynes-frontend/src/debugger/mod.rs, crates/rustynes-ppu/src/ppu.rs, crates/rustynes-test-harness/tests/accuracycoin.rs	UI preparation is separated from GPU painting. PPU helper execution is optimized without changing output. AccuracyCoin now requires zero failing tests.
Release and provenance records Cargo.toml, .github/release-notes/*, CHANGELOG*.md, README.md, NOTICE, docs/*, VERSION-PLAN.md, AGENTS.md	Project metadata and documentation now identify v2.3.0 “Datum II,” its validation results, licensing status, performance measurements, and provenance references.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant DetachedManager
  participant DebuggerOverlay
  participant Gfx
  App->>DetachedManager: Reconcile detached panels and route events
  DetachedManager->>DebuggerOverlay: Build panel UI
  DebuggerOverlay-->>DetachedManager: Return prepared frame
  DetachedManager->>Gfx: Acquire surface and present frame

Loading

Possibly related PRs

• doublegate/RustyNES#339: Shares the AccuracyCoin 141/141 validation context.
• doublegate/RustyNES#343: Shares the v2.3.0 provenance and PPU timing remediation.
• doublegate/RustyNES#346: Provides the related detachable-window framework and debugger panel API changes.

🚥 Pre-merge checks | ✅ 8 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Changelog Entry For User-Visible Changes	⚠️ Warning	The PR adds user-visible OS tool windows and frame-pacing fixes, but CHANGELOG.md leaves [Unreleased] empty and documents them only under [2.3.0].	Add a concise entry for the user-visible tool-window and frame-pacing changes under CHANGELOG.md's [Unreleased] heading.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the v2.3.0 release, PPU-accuracy work, and true multi-viewport tool-window implementation.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Docs-As-Spec Sync	✅ Passed	Target-crate changes are mapper comments plus byte-identical PPU optimizations; no CPU/APU behavior changed, and docs/performance records the PPU results and identity checks.
No Unwrap/Expect/Panic On Untrusted Input	✅ Passed	The full bcc9c76..HEAD diff adds no .unwrap(), .expect(), or panic!() calls; the new AccuracyCoin assertion is test code, and other matches predate the PR.
Safety Comment On New Unsafe Blocks	✅ Passed	The PR diff adds no unsafe { ... } blocks or unsafe fn; added unsafe occurrences are documentation only. Existing frontend unsafe blocks retain nearby // SAFETY: comments.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/v2.3.0-datum-ii

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Cuts v2.3.0 “Datum II” and aligns the repo with the release’s stated goals: true native multi-window tool panels, frame-pacing improvements, and tightened accuracy/provenance/packaging gates.

Changes:

• Introduces/rewires “detachable” debugger/tools windows to support real OS windows on native targets (plus supporting UI/plumbing changes).
• Tightens the AccuracyCoin gate by asserting zero failing tests (141/141) in CI, and updates release-facing version/license metadata to GPL-3.0-or-later.
• Updates documentation, release notes, packaging, and provenance headers to reflect the new licensing/provenance posture and corrected terminology.

Reviewed changes

Copilot reviewed 129 out of 133 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
to-dos/plans/v2.0.2-harbor-plan.md	Corrects TriCNES characterization wording in historical plan notes.
SUPPORT.md	Updates “current release” and license FAQ text (needs v2.3.0 consistency fix).
ROADMAP.md	Updates license statement in roadmap overview.
mkdocs.yml	Adds provenance/licensing docs to MkDocs navigation.
LICENSE-MIT	Removes MIT license file as part of relicense.
docs/scheduler.md	Clarifies performance targets as aspirational and points to measured numbers.
docs/SALVAGE_MANIFEST.md	Adjusts manifest text around removed/vendored items.
docs/hd-pack-zelda-troubleshooting.md	Updates reference path wording to avoid in-tree ref-proj paths.
docs/DOCUMENTATION_INDEX.md	Adds a provenance/licensing index section and links.
docs/adr/0006-vrc7-audio-landed.md	Updates reference path wording.
deny.toml	Updates license allowlist commentary and includes GPL-3.0-or-later.
crates/rustynes-test-harness/tests/accuracycoin.rs	Adds a strict “zero failing tests” AccuracyCoin regression guard.
crates/rustynes-test-harness/src/bin/pgo_trainer.rs	Adds SPDX/provenance header for a derived PGO trainer harness.
crates/rustynes-ppu/src/palette_gen.rs	Adds SPDX/provenance header for palette generation provenance notes.
crates/rustynes-mappers/src/sachen_8259.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/mmc3_clones.rs	Adds SPDX/provenance header and clarifies derived portions.
crates/rustynes-mappers/src/m513_sachen_9602.rs	Adds SPDX/provenance header and clarifies derived portions.
crates/rustynes-mappers/src/m268_bmc_coolboy.rs	Adds SPDX/provenance header and clarifies derived portions.
crates/rustynes-mappers/src/m250_nitra250.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m246_fong_shen_bang246.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m244_cne_decathlon.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m241_bxrom241.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m240_cne_multicart.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m232_camerica_bf9096.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m185_cnrom185.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m180_nichibutsu180.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m156_daou156.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m132_txc_22211.rs	Clarifies GeraNES cross-reference wording in decode comment.
crates/rustynes-mappers/src/m113_ave_nina006.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m107_magic_dragon107.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m096_bandai96.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m093_sunsoft3r.rs	Replaces quoted source line/path with independent-behavior wording.
crates/rustynes-mappers/src/m089_sunsoft2.rs	Replaces quoted source behavior with independent-behavior wording.
crates/rustynes-mappers/src/m079_ave_nina03_06.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m069_sunsoft_fme7.rs	Adds SPDX/provenance header for derived/cross-referenced detail.
crates/rustynes-mappers/src/m041_caltron41.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m039_subor39.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m038_bitcorp38.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/m035_jy_asic.rs	Adds SPDX/provenance header and removes in-tree ref-proj path mention.
crates/rustynes-mappers/src/m024_vrc6.rs	Clarifies wording around “ref-proj field” to avoid in-tree implication.
crates/rustynes-mappers/src/m016_bandai_fcg.rs	Adds SPDX/provenance header and clarifies derivation statement.
crates/rustynes-mappers/src/lib.rs	Adds SPDX/provenance header and clarifies derivation in mapper dispatch notes.
crates/rustynes-mappers/src/kaiser.rs	Adds SPDX/provenance header and clarifies derived implementation statement.
crates/rustynes-mappers/src/jaleco_discrete.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/homebrew_boards.rs	Rewords reference-emulator citation to “cross-referenced, not copied”.
crates/rustynes-mappers/src/fds.rs	Adds SPDX/provenance header and clarifies derived table statement.
crates/rustynes-libretro/rustynes_libretro.info	Updates libretro core metadata for GPL + v2.3.0 version.
crates/rustynes-gfx-shaders/src/crt_stack.rs	Adds SPDX/provenance header for shader reimplementation provenance.
crates/rustynes-frontend/src/ntsc_bisqwit.rs	Adds SPDX/provenance header and updates commentary to reflect derivation.
crates/rustynes-frontend/src/lib.rs	Adds native-only detached module export.
crates/rustynes-frontend/src/icons.rs	Updates icon documentation and adds detach/reattach glyph constants.
crates/rustynes-frontend/src/emu_thread.rs	Adds lock-free has_rom() accessor for frame pacing.
crates/rustynes-frontend/src/debugger/trace_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/tastudio_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/source_map.rs	Adds SPDX/provenance header and clarifies derivation statement.
crates/rustynes-frontend/src/debugger/script_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/rom_info_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/replay_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/ppu_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/perf_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/nsf_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/memory_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/memory_compare_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/mapper_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/input_rebind_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/input_miniatures_panel.rs	Routes panel through shared detachable window helper; updates reference wording.
crates/rustynes-frontend/src/debugger/header_editor.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/hd_pixel_panel.rs	Updates reference wording to avoid in-tree ref-proj paths.
crates/rustynes-frontend/src/debugger/game_db_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/event_panel.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/debugger/doc_panel.rs	Routes panel through shared detachable window helper; updates license string (needs accuracy/features consistency fix).
crates/rustynes-frontend/src/debugger/cpu_panel.rs	Routes panel through shared detachable window helper; updates signature.
crates/rustynes-frontend/src/debugger/audio_mixer.rs	Routes panel through shared detachable window helper.
crates/rustynes-frontend/src/crt.rs	Updates reference wording to avoid in-tree ref-proj paths.
crates/rustynes-frontend/src/cli.rs	Updates CLI “License …” text to GPL-3.0-or-later.
crates/rustynes-core/src/movie_interop.rs	Updates reference wording to avoid in-tree ref-proj paths.
crates/rustynes-cheevos/Cargo.toml	Updates crate license metadata to GPL-3.0-or-later.
crates/rustynes-apu/src/opll.rs	Adds SPDX/provenance header for emu2413-derived implementation.
crates/rustynes-apu/src/blip.rs	Adds SPDX/provenance header and clarifies derivation statement.
CONTRIBUTING.md	Updates contribution licensing language for GPL-3.0-or-later.
CHANGELOG-FULL.md	Corrects TriCNES characterization wording in historical changelog entry.
Cargo.toml	Bumps workspace version to 2.3.0 and updates workspace license metadata.
android/app/src/main/res/values/strings.xml	Updates Android About text for GPL + 141/141 + mapper count.
android/app/src/main/res/values-es/strings.xml	Updates Spanish Android About text for GPL + 141/141 + mapper count.
.gitignore	Adds/expands reference-firewall documentation for ref-proj ignore.
.github/workflows/release.yml	Updates release packaging to include LICENSE (not MIT/Apache files).
.github/release-notes/v2.0.2.md	Corrects TriCNES characterization wording in published historical notes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 25

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/release-notes/v2.0.2.md:
- Line 24: Update the TriCNES provenance reference in the release note to use
the current path crates/rustynes-test-harness/golden/tricnes/tricnes-full-src/
instead of ref-proj/TriCNES/Emulator.cs, or explicitly mark the old path as
historical if retaining it. Keep the existing emulator and commit attribution
unchanged.

In @.github/release-notes/v2.2.5.md:
- Around line 9-12: Update the v2.2.5 release-note provenance paragraphs around
the claims that no GPL-licensed emulator source was incorporated so they are
clearly labeled as superseded historical statements and link to the corrective
disclosure in CHANGELOG.md or NOTICE. Do not present those license or provenance
conclusions as current facts, while preserving the historical context of the
release note.

In `@AGENTS.md`:
- Line 201: Synchronize the stale release guidance in AGENTS.md: update the
current-release declaration near the top to v2.3.0 “Datum II,” and revise the
forward-plan text so v2.3.0 is described as shipped and not a future store
launch. Mark obsolete v2.2.9/current-release and store-launch statements as
historical or replace them with the established v2.3.0 guidance, preserving the
repository’s release-policy wording.

In `@CHANGELOG.md`:
- Around line 419-421: Update the v2.2.3 summary in the changelog to remove the
inaccurate claim of zero shipped-default behavior change; state that there was
no regression or precisely identify only the unchanged surface, while keeping
the documented PPU-path, mapper, audio-calibration, and snapshot changes in the
same entry consistent.

In `@crates/rustynes-frontend/src/app.rs`:
- Around line 8762-8776: The phase-1/phase-2 lock-scope invariant lacks
regression protection. Add a debug-only re-entrancy or lock-held check tied to
EmuHandle::lock and paint_shell/overlay, asserting that paint_shell and the
overlay/extra closure do not acquire the emulator lock after phase 1; preserve
the existing snapshot-based native extra path and avoid affecting release
builds.
- Line 4115: Update the documentation comment adjacent to the replay-interaction
lockout to state that the independent implementation was compared against the
GeraNES reference emulator as a black-box oracle, rather than saying it mirrors
or derives from GeraNES. Preserve the provenance attribution while making clear
no porting or derivation is claimed.
- Around line 3998-4003: Move the detached.request_redraw_tick() call from
on_emu_frame into post_produce_housekeeping so every native frame-production
path updates detached-panel throttle ticks, including builds without emu-thread.
Preserve the existing non-wasm conditional and remove the original call to avoid
duplicate redraw ticks.
- Around line 8007-8023: Update the detached-window creation failure branch in
the reconcile loop around DetachedManager::create to reattach the failed panel
through the existing DebuggerOverlay reattachment path. Remove the panel id from
DebuggerOverlay::detached_panels or otherwise invoke its established reattach
operation after logging the error, so the panel becomes docked again and
subsequent event-loop iterations do not retry creation.

In `@crates/rustynes-frontend/src/debugger/cpu_panel.rs`:
- Line 100: Add an adjacent explanatory comment to the local
#[allow(clippy::too_many_arguments)] attribute for CpuPanelState::show,
documenting why its current argument list must remain; do not alter the method
signature or introduce a context struct unless choosing that alternative
instead.

In `@crates/rustynes-frontend/src/debugger/mod.rs`:
- Around line 396-436: Update the detached-panel lifecycle around
detachable_window and render_detached_body to detect when a detached target
produces no content because its show flag or eligibility condition was cleared.
Track whether the detached target rendered, reset that state before dispatch,
and remove the target from detached_panels when dispatch paints nothing so
App::reconcile_detached closes the orphaned window. Preserve normal rendering
and reattach behavior for targets that do produce content.
- Around line 1694-1697: In DebuggerOverlay::render_detached_body, stop calling
crate::ui_shell::apply_theme unconditionally on every repaint. Add a
per-detached-target theme cache, such as detached_theme keyed by the target’s
static panel identifier, and apply the theme only when that cached value
differs; do not reuse self.last_theme because it belongs to the main window.
Optionally remove the target entry in App::handle_detached_window_event when the
detached window closes.

In `@crates/rustynes-frontend/src/detached.rs`:
- Around line 291-306: Update render_ui to inspect output.viewport_output for
the zero repaint_delay request, and call request_redraw on the corresponding
detached window when egui requests another frame. Preserve the existing frame
preparation and platform-output handling while ensuring OnInteraction
repaint-driven animations re-arm redraws.
- Around line 329-337: Apply the prepared egui texture delta, including both set
and free entries, before the w.surface.get_current_texture call in the detached
render flow. Preserve the existing Lost/Outdated reconfiguration behavior, and
request a redraw after reconfiguring so the window retries rendering without
waiting for another event; ensure the later texture-update loops do not apply
the same delta twice.

In `@crates/rustynes-frontend/src/emu_thread.rs`:
- Around line 303-315: Update the doc comment for EmuThread::has_rom to describe
the operation as a single Acquire load, removing the contradictory
“relaxed-acquire” wording; leave the implementation and synchronization behavior
unchanged.

In `@crates/rustynes-frontend/src/gfx.rs`:
- Around line 796-816: In the detached surface configuration flow, validate the
capabilities returned by surface.get_capabilities(&self.adapter) before
selecting format or alpha_mode. If both caps.formats and caps.alpha_modes are
empty, return GfxError::Surface(...) so DetachedManager::create can log the
failure; otherwise preserve the existing sRGB selection and configuration
behavior.

In `@crates/rustynes-ppu/src/ppu.rs`:
- Around line 4314-4318: Update the inline rationale for
tick_sprite_eval_per_dot in crates/rustynes-ppu/src/ppu.rs lines 4314-4318 to
say it runs once per eligible rendered dot, or use the measured eligible-dot
count instead of 89,342. Update the corresponding profiling record in
docs/performance.md lines 587-590 with the same call-count wording so both
performance records match the implementation.

In `@crates/rustynes-test-harness/tests/accuracycoin.rs`:
- Around line 336-357: Update the AccuracyCoin assertions near the existing
failing.is_empty() guard to explicitly count result categories: require zero
Fail plus Unknown results, exactly 141 Pass plus PassWithCode results, and
reject or otherwise explicitly handle skipped tests. Do not rely on the existing
60% assigned-test threshold or failing list alone; preserve the regression
message context while enforcing complete execution of all 141 tests.

In `@docs/originality-and-provenance.md`:
- Around line 139-167: Revise the definitive licensing conclusions in the
GeraNES discussion to present them as a provisional assessment subject to human
and expert review. Retain the source-consultation evidence, independent
implementation details, and provenance disclosure, but replace claims that no
GPL code was incorporated and that the GPL-3.0-or-later grant stands with
appropriately qualified uncertainty.

In `@docs/scheduler.md`:
- Around line 157-163: Correct the Frame cost metric in the scheduler design
aspirations to match the workload conditions documented in the performance
Targets section. Remove the “no rendering” label from the ~3.9 ms nestest value,
and either identify it as headless core only where supported or distinguish the
rendering-enabled nestest and rendering-disabled flowing_palette measurements.

In `@NOTICE`:
- Around line 61-73: Replace the GeraNES provenance statements at NOTICE (lines
61-73), .github/release-notes/v2.3.0.md (line 50), and CHANGELOG.md (lines
102-105) with one consistent, qualified statement: separately describe source
consultation and avoid definitive conclusions about copying or copyrightability,
explicitly note that the legal classification is uncertain and requires human
and expert review, and preserve the documented-behavior/no-incorporated-code
context.

In `@README.md`:
- Line 88: Update the mapper-family count in SUPPORT.md to match the
authoritative 172 mapper families stated in the README.md Highlights table,
preserving the surrounding support description and terminology.
- Around line 409-413: Update the README description of native panel detaching
near the TAStudio and Audio Mixer list to state that the Detach button opens
panels as separate OS windows, matching the current-release behavior and
existing documentation.

In `@SUPPORT.md`:
- Line 97: Update the roadmap link in the release description to target the
authoritative current roadmap at to-dos/ROADMAP.md instead of the stale root
ROADMAP.md, while preserving the surrounding v2.3.0 release text.

In `@VERSION-PLAN.md`:
- Line 97: Correct the AccuracyCoin timeline in VERSION-PLAN.md: do not claim
141/141 throughout v2.x, and state that the exact 141/141 result applies from
v2.0.3 onward while documenting the v2.0.2 139/141 exception. Keep the wording
consistent with the authoritative entries in CHANGELOG-FULL.md.
- Around line 79-82: Update VERSION-PLAN.md by removing the duplicate v2.3.0
“Datum II” in-progress row and revising the “Forward path” paragraph to describe
work after the shipped v2.3.0 release. Keep the existing current v2.3.0 row and
preserve the documented open-source, income-free policy while removing
references that identify v2.2.6 → v2.3.0 as the active line.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8cdda054-0944-424d-a608-8cbe37047b20

📥 Commits

Reviewing files that changed from the base of the PR and between bcc9c76 and 306410c.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock, !Cargo.lock

📒 Files selected for processing (68)

• .github/release-notes/v2.0.2.md
• .github/release-notes/v2.2.5.md
• .github/release-notes/v2.3.0.md
• AGENTS.md
• CHANGELOG-FULL.md
• CHANGELOG.md
• Cargo.toml
• NOTICE
• README.md
• SUPPORT.md
• VERSION-PLAN.md
• crates/rustynes-frontend/src/app.rs
• crates/rustynes-frontend/src/av_record.rs
• crates/rustynes-frontend/src/cli.rs
• crates/rustynes-frontend/src/debugger/basic_bot_panel.rs
• crates/rustynes-frontend/src/debugger/cheevos_panel.rs
• crates/rustynes-frontend/src/debugger/cpu_panel.rs
• crates/rustynes-frontend/src/debugger/doc_panel.rs
• crates/rustynes-frontend/src/debugger/hd_pixel_panel.rs
• crates/rustynes-frontend/src/debugger/header_editor.rs
• crates/rustynes-frontend/src/debugger/input_miniatures_panel.rs
• crates/rustynes-frontend/src/debugger/input_rebind_panel.rs
• crates/rustynes-frontend/src/debugger/mod.rs
• crates/rustynes-frontend/src/debugger/netplay_panel.rs
• crates/rustynes-frontend/src/debugger/script_panel.rs
• crates/rustynes-frontend/src/debugger/settings_panel.rs
• crates/rustynes-frontend/src/debugger/tastudio_panel.rs
• crates/rustynes-frontend/src/detached.rs
• crates/rustynes-frontend/src/emu_thread.rs
• crates/rustynes-frontend/src/gfx.rs
• crates/rustynes-frontend/src/icons.rs
• crates/rustynes-frontend/src/lib.rs
• crates/rustynes-frontend/src/shader_pass.rs
• crates/rustynes-frontend/src/ui_shell.rs
• crates/rustynes-libretro/rustynes_libretro.info
• crates/rustynes-mappers/src/homebrew_boards.rs
• crates/rustynes-mappers/src/jaleco_discrete.rs
• crates/rustynes-mappers/src/m038_bitcorp38.rs
• crates/rustynes-mappers/src/m039_subor39.rs
• crates/rustynes-mappers/src/m041_caltron41.rs
• crates/rustynes-mappers/src/m079_ave_nina03_06.rs
• crates/rustynes-mappers/src/m089_sunsoft2.rs
• crates/rustynes-mappers/src/m093_sunsoft3r.rs
• crates/rustynes-mappers/src/m096_bandai96.rs
• crates/rustynes-mappers/src/m107_magic_dragon107.rs
• crates/rustynes-mappers/src/m113_ave_nina006.rs
• crates/rustynes-mappers/src/m132_txc_22211.rs
• crates/rustynes-mappers/src/m156_daou156.rs
• crates/rustynes-mappers/src/m180_nichibutsu180.rs
• crates/rustynes-mappers/src/m185_cnrom185.rs
• crates/rustynes-mappers/src/m232_camerica_bf9096.rs
• crates/rustynes-mappers/src/m240_cne_multicart.rs
• crates/rustynes-mappers/src/m241_bxrom241.rs
• crates/rustynes-mappers/src/m244_cne_decathlon.rs
• crates/rustynes-mappers/src/m246_fong_shen_bang246.rs
• crates/rustynes-mappers/src/m250_nitra250.rs
• crates/rustynes-mappers/src/multicart_discrete.rs
• crates/rustynes-mappers/src/ntdec.rs
• crates/rustynes-mappers/src/sachen_8259.rs
• crates/rustynes-mappers/src/sachen_discrete.rs
• crates/rustynes-ppu/src/ppu.rs
• crates/rustynes-test-harness/tests/accuracycoin.rs
• docs/STATUS.md
• docs/adr/0030-accuracycoin-ale-read-hybrid-addresses-octal-latch.md
• docs/originality-and-provenance.md
• docs/performance.md
• docs/scheduler.md
• to-dos/plans/v2.0.2-harbor-plan.md

[doublegate]

Review closeout — all 25 CodeRabbit findings + the Antigravity blocker addressed

Thanks — this review caught four real defects that would have shipped, one of them permanent-corruption class. Everything below is fixed in 8983b26a and 8a66ae40.

Functional defects (fixed)

Finding	Why it mattered
detached.rs — texture-delta discard (🔴 Critical)	present() acquired the swapchain before applying egui's texture delta and early-returned on Lost/Outdated. That delta is one-shot — a single transient surface error (resize, monitor change) meant the font atlas never reached the renderer and the window stayed blank/garbled permanently. Uploads now precede any bail-out; frees run on every exit path via one helper.
app.rs — failed create retried forever (Antigravity blocker)	The id stayed in the detached set while has_panel stayed false, so reconcile_detached retried every about_to_wait with an eprintln! each time. Now reattaches on failure: degrades to in-window, reports once, cannot spin.
mod.rs — orphaned OS window (🟠 Major)	Every call site is if self.show_x { … }, so clearing the flag while detached meant nothing removed the id. Reachable without touching the window — clear_tas_editor fires on every ROM load. Fixed with a painted-target check that reattaches.
app.rs:4003 — redraw tick under the wrong cfg (🟠 Major)	request_redraw_tick() lived in on_emu_frame, compiled only under emu-thread; synchronous paths run post_produce_housekeeping, so detached tiers froze in an emu-thread-off build. Moved to the shared point.
gfx.rs:816 — panic on empty surface caps (🟠 Major)	The retained adapter was chosen with compatible_surface for the main window, so caps.formats[0] could panic the emulator while merely opening a tool window. Both now return GfxError::Surface, which already degrades to "panel stays docked".
detached.rs:306 — discarded repaint request (🟠 Major)	OnInteraction is the one tier that never re-arms from the frame clock, so egui-driven hover/active transitions froze mid-animation. Now honoured.
accuracycoin.rs:357 — gate proved less than it looked (🟡)	You're right: failing.is_empty() only covers Fail/Unknown, so an under-executing battery passed — the same "absent looks like success" shape the guard exists to prevent. Now also asserts exactly EXPECTED_PASS_COUNT == 141. Re-run green.
app.rs:8776 — unguarded lock-scope invariant (🔵)	Implemented your suggestion: EmuHandle::lock trips a debug_assert when reached from the GPU phase, armed by an RAII guard around the overlay closure. Zero cost in release, not compiled on wasm.

Provenance honesty (fixed)

originality-and-provenance.md:167 and NOTICE:73 are the most important comments in this review. The GeraNES text was written as a conclusion — "no GeraNES code is copied; GPL-3.0-or-later stands" — which is exactly the self-certification this project's own guardrails forbid. The rule exists for a documented reason: the original provenance failure was caught by an outside NESdev reviewer, not by the project's tooling or by the AI assistance that wrote the code.

NOTICE, the originality doc, the v2.3.0 release note and CHANGELOG.md now carry one consistent qualified statement — evidence and two-sided review retained, result stated as an assessment for expert review, with the residual uncertainties named explicitly (whether a coincidence is "the single correct expression of a documented fact" is a legal judgement; the review covered the files the comments pointed at rather than proving absence elsewhere).

.github/release-notes/v2.2.5.md also still asserted "No GPL-licensed emulator source is incorporated" — withdrawn by the v2.2.9 relicense. It now opens with a superseded banner naming the correction, original text retained unedited beneath. The published GitHub release was updated to match. Correcting a bad provenance claim in the open, never quietly rewriting it.

Documentation drift (fixed)

All of it, and the mapper-count one was worse than reported: SUPPORT.md advertised 51 families (actual: 172) and sent users to the pre-1.0 root ROADMAP.md from three places. Also fixed: README.md still describing Detach as staying inside the main window (the exact limitation this release removes), AGENTS.md contradicting itself on the current release, VERSION-PLAN.md listing v2.3.0 twice and claiming 141/141 "throughout the v2.x line" (v2.0.1–v2.0.2 shipped an honest 139/141), the v2.2.3 entry claiming "zero shipped-default behavior change" while documenting several, docs/scheduler.md mislabelling a rendering workload as "no rendering", the v2.0.2 note pointing at the removed ref-proj/ clone, and the unjustified #[allow] on cpu_panel::show.

Two of my own overstatements corrected in the same pass: tick_sprite_eval_per_dot runs once per eligible dot (up to 61,440/frame), not all 89,342 — idle lines and rendering-disabled paths bypass it; and an Acquire load was described as "relaxed-acquire" in a file where ordering is load-bearing.

Declined, with reasons

• is_multiple_of → % (Antigravity): the MSRV is 1.96, well past the 1.85 stabilisation, and clippy -D warnings actively requires is_multiple_of here (manual_is_multiple_of). Reverting would fail the lint gate.
• GPLv3 → SPDX GPL-3.0-or-later in the libretro .info (Antigravity nitpick): checked against the ecosystem rather than assumed — mesen, melonDS and bsnes are all GPLv3-or-later and all write exactly GPLv3. libretro .info uses short display strings, not SPDX; the Cargo metadata correctly stays SPDX.

Gates: fmt; clippy --workspace --all-targets -D warnings; wasm clippy; markdownlint; AccuracyCoin re-run green at exactly 141/141.

[github-actions]

Antigravity review (Gemini via Ultra)

Error: timeout waiting for response

_{Automated first-pass review by agy on a self-hosted runner -- not a human review.}