fix(slack-bot): match all open blog PRs in #N resolver, not just drafts#25
Merged
superterran merged 1 commit intomainfrom May 4, 2026
Merged
fix(slack-bot): match all open blog PRs in #N resolver, not just drafts#25superterran merged 1 commit intomainfrom
superterran merged 1 commit intomainfrom
Conversation
pr-creator.js opens posts ready-for-review (commit 5ddb53c removed --draft), but getLatestIdeaBatch was filtering on pr.draft === true so the batch came back empty and "#3 ..." replies fell through to the slug-matching parseIntent path, which failed to find unmerged drafts in main. Drop the draft requirement; identify the batch purely by the blog/YYYY-MM-DD- branch prefix instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24. The `#N` resolver was filtering on `pr.draft === true`, but `pr-creator.js` opens posts ready-for-review (since 5ddb53c). With the filter, the batch came back empty and `#3 …` replies fell through to the slug-matching path, which can't find unmerged drafts in `main`.
Drop the draft requirement — group purely by the `blog/YYYY-MM-DD-…` branch prefix.
Test plan