Fix composer model picker visibility and selection - #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause\nThe composer utility row and model-control wrapper both used overflow: hidden. The picker opens upward and extends horizontally, so Windows/browser hit-testing could not reach its options; the menu closed without changing the selected model.\n\n## Fix\n- allow the composer utility row and model-control wrapper to show the picker\n- add desktop end-to-end coverage for selecting and persisting a model\n- add compact viewport coverage for option bounds and selection\n\n## Verification\n- npm run lint\n- npm run typecheck\n- 60 frontend unit tests\n- 12 Playwright tests\n- npm run build\n- reproduced in the live browser before and after the fix