Skip to content

Drop the mutable default in _estimate_size_in_bytes #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Apr 12, 2026
+6 −2
Merged

Drop the mutable default in _estimate_size_in_bytes #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kafka/producer/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,9 @@ def max_usable_produce_magic(cls, api_version):
else:
return 0

def _estimate_size_in_bytes(self, key, value, headers=[]):
def _estimate_size_in_bytes(self, key, value, headers=None):
if headers is None:
headers = []
magic = self.max_usable_produce_magic(self.config['api_version'])
if magic == 2:
return DefaultRecordBatchBuilder.estimate_size_in_bytes(
Expand Down
4 changes: 3 additions & 1 deletion kafka/record/memory_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,13 @@ def skip(self, offsets_to_skip):
# Exposed for testing compacted records
self._next_offset += offsets_to_skip

def append(self, timestamp, key, value, headers=[]):
def append(self, timestamp, key, value, headers=None):
""" Append a message to the buffer.

Returns: RecordMetadata or None if unable to append
"""
if headers is None:
headers = []
if self._closed:
return None

Expand Down
Loading