fix(BREAKING): remove anyhow - #9
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_textnever returned anErr— every path wasOk(...)— so rather than introduce an error type that can never be constructed, this drops theResultentirely and returnsOption<String>.anyhowdependencyformat_textnow returnsOption<String>instead ofanyhow::Result<Option<String>>wasm_plugin.rsdrops the now-unnecessary.map_err(FormatError::new)?dprint-development0.10.1 -> 0.11.0, whoserun_specscallback returnsResult<Option<String>, Box<dyn Error + Send + Sync>>rather than an anyhow resultAlso in here:
Cargo.lockis no longer gitignored, and is now committeddeno.jsonusesjsr:@dprint/automation@0.12.2instead of the raw.githubusercontent URLs at 0.10.0. The JSR package only exports.and./tasks/publish-release, so the"automation/"prefix mapping is gone andgenerateReleaseNotes.tsimportsgenerateChangeLogfrom the root export (mod.tsre-exports./changelog.ts). The release workflow's pinnedpublish-releasetask moved 0.10.3 -> 0.12.2 to match.deno.lockwas deleted and regenerated withdeno install.scripts/update.ts, which had a$.log(...)line over the line widthBREAKING:
format_text's signature changed, so callers doingformat_text(..)?need to drop the?.