[npm] Bump @types/node to ^26.1.1 across client, client-v3, electron#1293
Merged
Conversation
typescript stays on ^6.0.3 for now: typescript-eslint@8.63.0's peer range (>=4.8.4 <6.1.0) blocks TypeScript 7, and TS 7.0 doesn't ship a compiler API yet, so bumping it would break ESLint's type-aware linting in CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
The initial npm install left the encoding/iconv-lite optional peer dependency (pulled in transitively by minipass-fetch) out of the lock file, so npm ci failed with EUSAGE on CI. Regenerating package-lock.json from scratch (not just node_modules) restores it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodefrom~20.14.0/>=22.12.0/^22.0.0to^26.1.1inclient/,client-v3/, andelectron/respectively, keeping all three packages on a consistent floor.typescriptat^6.0.3in all three — TypeScript 7.0 ships without a compiler API (onlytscgot the native Go port; the API is promised for 7.1), andtypescript-eslint@8.63.0(already latest, already in use) hard-pins its peer range totypescript: >=4.8.4 <6.1.0. The upstream tracking issue for TS7 support was closed "not planned," so bumpingtypescriptnow would break ESLint's type-aware linting and bothnodelint.ymlCI jobs. Revisit oncetypescript-eslintadds support.Test plan
npm installclean (no peer dependency warnings) inclient/,client-v3/,electron/npm run typecheckpasses in all threenpm run ci-lintpasses in all three (confirms type-aware ESLint rules still work, sincetypescriptis unchanged)npm run buildpasses inclient/andclient-v3/npm run test:runpasses inclient/(132 tests) andclient-v3/(39 tests)🤖 Generated with Claude Code