fix(deps): update module github.com/gofiber/fiber/v3 to v3.2.0 [security]#78
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): update module github.com/gofiber/fiber/v3 to v3.2.0 [security]#78renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v3.1.0→v3.2.0Fiber's cache middleware default key generator ignores query string, causing response mix-up across distinct query parameters
CVE-2026-30246 / GHSA-35hp-hqmv-8qg8
More information
Details
Summary
Fiber cache middleware's default key generator uses only
c.Path()and does not include the query string.As a result, requests like
/?id=1and/?id=2can map to the same cache key and share the same cached response.This can cause response mix-up (cache poisoning-like behavior) for endpoints where response content depends on query parameters.
Details
Default configuration in cache middleware:
KeyGenerator: func(c fiber.Ctx) string { return utils.CopyString(c.Path()) }References:
The existing test demonstrates that when handler output depends on query parameter
id, a second request with a different query still returns the first cached response (cache hit), confirming query is not part of the default cache key.PoC
Minimal PoC:
Reproduction:
GET /?id=11GET /?id=21(expected2)Local verification command used:
go test ./middleware/cache -run Test_Cache_WithNoCacheRequestDirective -count=1Observed result: test passes, confirming this is current behavior.
Impact
Suggested remediation
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Fiber vulnerable to XSS in AutoFormat Content Negotiation
CVE-2026-42554 / GHSA-qjv7-627w-8qjv
More information
Details
Summary
Description
A Cross-Site Scripting (CWE-79) vulnerability in Go Fiber allows a remote attacker to inject arbitrary HTML/JavaScript by supplying
Accept: text/htmlon any request whose handler passes attacker-influenced data to the AutoFormat() feature. This affectsgithub.com/gofiber/fiber/v3(DefaultRes.AutoFormat) through version 3.1.0 andgithub.com/gofiber/fiber/v2(Ctx.Format) through version 2.52.12.The developer opts into content negotiation by calling AutoFormat(), but does not opt into raw HTML emission for a particular request; Fiber chooses that branch from attacker-controlled Accept. Five of the six branches of the same method already escape.
JSON,XML,MsgPack, andCBORall route through encoders that neutralize markup; the txt branch emitstext/plainand cannot execute. The html branch is the sole outlier in a method whose name (AutoFormat) and symmetrical structure actively telegraph "safe, format-agnostic reply."Details
The issue resides in
res.gowithin(*DefaultRes).AutoFormat(). The method negotiates against the request Accept header, selects one ofhtml | json | txt | xml | msgpack | cbor, and serializes the caller-supplied body accordingly.The "html" branch concatenates the stringified body directly into HTML markup with no output encoding:
acceptcomes fromr.c.Accepts(...), i.e. is fully attacker-controlled. An attacker can force the "html" branch on anyAutoFormat()call regardless of which format the developer tested against.bis produced frombodyvia direct assignment (string/[]byte) orfmt.Sprintf("%v", body). Nohtml.EscapeStringis applied.text/html; charset=utf-8, so browsers render it as active HTML.Impact
This impacts all current v3 releases ≤ 3.1.0 containing
DefaultRes.AutoFormat, and all current v2 releases ≤ 2.52.12 where the identical"<p>" + b + "</p>"construction exists in(*Ctx).Format(). Exploitation requires that an application callc.AutoFormat(v)wherev(or a field stringified by%v) contains request-influenced data.A handler that uses
AutoFormat()to serve multiple representations of the same data can be turned into an HTML XSS sink when the client sendsAccept: text/html, even if the developer only tested the JSON path.This may result in:
AutoFormat.AutoFormat.Proposed Patch
The injection surface is
r.Type("html")followed byr.SendString(b)with unescaped caller data, where it constructs markup on the caller's behalf around a value whose HTML-ness the caller did not declare. A few options:AutoFormat()should treatbodyas data, not markup, in the"html"branch and escape it before concatenating it into the framework-generated<p>wrapper. Callers that need raw negotiated HTML should useFormat()with an explicit HTML handler.AutoFormatalone for backward compatibility.HTML-escape the value in the "html" branch before concatenating it into the
<p>wrapper.html.EscapeStringescapes<,>,&,',", which is sufficient for an element-text context. Apply the same change to v2's(*Ctx).Format().Proof of Concept
Benign JSON
HTML sink enables XSS
Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:N/VI:N/VA:N/SC:L/SI:L/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
gofiber/fiber (github.com/gofiber/fiber/v3)
v3.2.0Compare Source
🚀 New
https://docs.gofiber.io/api/app#getroute
https://docs.gofiber.io/middleware/healthcheck#config
https://docs.gofiber.io/middleware/paginate
https://docs.gofiber.io/api/bind#binderror
https://docs.gofiber.io/middleware/recover#config
🧹 Updates
🐛 Fixes
End()to prevent panic in streaming mode (#4128)🛠️ Maintenance
43 changes
📚 Documentation
📒 Documentation: https://docs.gofiber.io/next/
💬 Discord: https://gofiber.io/discord
Full Changelog: gofiber/fiber@v3.1.0...v3.2.0
Thank you @JonasDoe, @ReneWerner87, @adrian-lin-1-0-0, @aviu16, @gaby, @ha-sante, @loderunner, @meruiden, @mutantkeyboard and @sixcolors for making this release possible.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.