chore(design-system): add vitest artifacts to gitignore [AR-48187]#334
chore(design-system): add vitest artifacts to gitignore [AR-48187]#334iromanchuk-dn wants to merge 3 commits intodrivenets:mainfrom
Conversation
iromanchuk-dn
requested review from
StyleShit,
aroba-dn,
mmurawski-dn and
vpolessky-dn
| __screenshots__ | ||
| .vitest-attachments |
There was a problem hiding this comment.
__screenshots__ shouldn't be ignored, we'll want to commit them at some point
Why do you need to ignore it? Are there any screenshots created locally?
There was a problem hiding this comment.
Are there any screenshots created locally?- exactly. Quite often Cursor agent executes tests and it generates screenshots.
There was a problem hiding this comment.
but why? do we have any toMatchScreenshot tests?
There was a problem hiding this comment.
I think AI does it to view the screenshot of failed test and understand what's wrong
There was a problem hiding this comment.
hmm
but then what will happen when we'll want to use screenshots ourselves? This ignore will block us, no?
There was a problem hiding this comment.
Probably it will, I will cancel this PR.
2 participants
No description provided.