Conversation
Older servers ignore the request body anyway.
Collaborator
Author
|
@r4victor, sorry for the huge PR. It's mostly boilerplate, but at least |
r4victor
reviewed
May 6, 2026
| async def get_gateway( | ||
| body: schemas.GetGatewayRequest, | ||
| session: AsyncSession = Depends(get_session), | ||
| user_project: Tuple[UserModel, ProjectModel] = Depends(ProjectMemberOrPublicAccess()), |
Collaborator
There was a problem hiding this comment.
It seems ProjectMemberOrPublicAccess() was used so that everyone could get gateways in public projects. Is the tightening intentional? Does the UI for public projects continue to work without problems?
Collaborator
Author
There was a problem hiding this comment.
Wasn't intentional, thanks
r4victor
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow exporting gateways to other projects.
Imported gateways can be used by specifying them in the
gatewayproperty in service configurations.Limitations:
#3851