Support multi-EFA instances with public IPs#3865
Merged
Conversation
Collaborator
Author
|
Ran NCCL tests on 2x p4d.24xlarge with public IPs. The results as the same as with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support launching AWS instances with multiple EFA interfaces and public IPs. Previously, multi-EFA instances required
public_ips: Falsebecause AWS can't automatically assign a public IP if an instance has multiple network interfaces. This limitation is dropped by explicitly allocating and assigning/releasing public IPs instead of relying on IP auto-assign.Tested launching
p4d.24xlargeineu-north-1: all EFA interfaces configured and public IP assigned. Also tested the same setup withpublic_ips: falsefor regressions.