Sets up linting, type checking, and testing rules and enforces them in new Github workflow#17
Merged
Conversation
This was
linked to
issues
Jul 21, 2025
alexbainter
approved these changes
Jul 21, 2025
Collaborator
alexbainter
left a comment
alexbainter
left a comment
There was a problem hiding this comment.
Nice! The dev tools introduced here are new to me, though I'm sure they're standard for Python. It’d be nice to have them mentioned in the README at some point for people like me (just a quick "here's how to set it up and use it" or a link), but totally fine if you planned to do that later--no pressure to include it in this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13 #14 #15
The diffs in the regular python files are just formatting changes enforced by ruff. In the
__init__.pyfiles, adding the redundant alias is done to communicate that these are purposefully "unused" imports that are being used to expose a public interface to other modules (see unused-import (F401)).As a starting point, I'm setting the minimum test coverage to 90%.