Creates stateless version of OAuth 2 functions in generic case#34
Merged
Conversation
lisad
approved these changes
Jul 24, 2025
| Scope: TypeAlias = str | set[object] | tuple[object] | list[object] | ||
|
|
||
|
|
||
| def generic_construct_authorization_url( |
Member
There was a problem hiding this comment.
There's no reason that the stateless methods need to be functional instead of object-oriented just because they're stateless, but this is fine of course!
Member
There was a problem hiding this comment.
For these to be used from outside the library when the library is packaged and installed via something like setup, these methods will need to be exported in an init.py in the main directory of the library, but that can be added.
aborem
added a commit
that referenced
this pull request
Jul 28, 2025
…e" (#38) Reverts #34 See discussion: #37 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30 and discussed in dtinit/pardner-site#10 (comment)
src/pardner/stateless/base.py, which are adapted from the base service transfer class and its methods created in Modifies BaseTransferService to have OAuth2 session as an attribute rather than extending it #24 Client session base class and library set up #16 . Eventually other stateless functions will use these to make their requests (they're essentially wrappers for these core ones).This doesn't change anything about the existing classes because using a class instance implies that you're okay with state, so making those optionally stateless is not necessary.