Skip to content

Update Tumblr's scope to basic instead of base #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aborem merged 1 commit into from
Aug 12, 2025
Merged

Update Tumblr's scope to basic instead of base #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pardner/services/tumblr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def __init__(

@override
def scope_for_verticals(self, verticals: Iterable[Vertical]) -> set[str]:
# Tumblr only needs 'base' for read access requests
return {'base'}
# Tumblr only needs 'basic' for read access requests
return {'basic'}

@override
def fetch_token(
Expand Down
2 changes: 1 addition & 1 deletion tests/test_transfer_services/test_tumblr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


@pytest.mark.parametrize(
['verticals', 'expected_scope'], [([], {'base'}), ([Vertical.FeedPost, {'base'}])]
['verticals', 'expected_scope'], [([], {'basic'}), ([Vertical.FeedPost, {'basic'}])]
)
def test_scope_for_vertical(mock_tumblr_transfer_service, verticals, expected_scope):
assert mock_tumblr_transfer_service.scope_for_verticals(verticals) == expected_scope