Convert application from Angular to React#523
Open
dylan-smith wants to merge 1 commit into
Open
Conversation
Replace the Angular 21 + Angular Material + Karma stack with React 19 + MUI 7 + Vite 7 + Vitest + Zustand while keeping every external contract intact: dev server port 4200, build output at dist/dive-intelligence/browser, and unit-test junit/cobertura artifact paths, so CI.yml is unchanged. - Buhlmann engine ported verbatim as plain TypeScript; BreathingGas cached fields became getters, removing the hand-rolled settings subscriber list - App state: single Zustand store holding a stable mutable DivePlanner with a version counter for React invalidation - 27 Angular components rebuilt as React + MUI, keeping font-based Material Icons and class names the Playwright page objects rely on - Plotly charts share a PlotlyChart wrapper (element refs, purge cleanup) with a MUI Dialog enlarged view - DivePlannerService spec ported to Vitest (28 empty spec stubs dropped); Playwright page objects updated for the MUI DOM Co-Authored-By: Claude <noreply@anthropic.com>
Unit Test Results4 tests - 2 4 ✅ - 2 0s ⏱️ ±0s Results for commit f73c1a1. ± Comparison against base commit f3fabc1. This pull request removes 6 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
This PR has been deployed to a preview site for testing. This site will automatically be deleted when the PR is merged. Last deployed: 2026-07-14T15:50:59Z (UTC) |
This was referenced Jul 14, 2026
Unit Tests Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/dive-intelligence/browser, junit/cobertura artifacts at the paths the coverage steps read, and the same npm script names (start,build,lint,ci-test,deploy,playwright)BreathingGascached fields became getters, which eliminated the hand-rolled settings subscriber pattern. App state is a single Zustand store holding a stable mutableDivePlannerwith a version counter for React invalidationmat-icon→.material-icons,mat-list-item→li+.MuiListItemText-*, etc.)DivePlannerServicespec ported to Vitest (the 28 empty component spec stubs were dropped); Playwright e2e suite retained as the behavioral safety netTest plan
npm run ci-test— 4/4 engine tests pass; junit + cobertura emitted at CI-expected pathsnpm run lintandnpm run build— clean; output containsassets/config.json+ sourcemaps for the instrumentation-key injection and sourcemap upload stepsnpx playwright test --project=chromium— all 3 scenarios pass against the dev server (including the full deco-dive-to-100m assertions)vite preview— passes🤖 Generated with Claude Code