Feature/simple file server with node18 support#64
Merged
marioserrano09 merged 2 commits intoMay 18, 2026
Conversation
…startup with environment info and resource fetching
There was a problem hiding this comment.
Pull request overview
Version bump from 26.5.0 to 26.5.1 across all Maven and npm packages, with two functional changes targeting Node 18 support and embedded usage of simple-file-server, plus a small refactor in RemoteEntityFileStorage.
Changes:
- Bump all module versions (Maven
pom.xml, npmpackage.json, lockfiles) from26.5.0→26.5.1. simple-file-server: lower Node engine requirement to>=18.17.0, downgradefile-typeto^20.0.0,startServernow returnsSFSRuntime, CLI prints environment info / server summary, README + embedded-mode example added.RemoteEntityFileStorage.fetchResource: simplify torestClient...body(Resource.class)instead of manually wrapping anInputStreaminInputStreamResource.
Reviewed changes
Copilot reviewed 62 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml, themes/**/pom.xml, platform/**/pom.xml, extensions/**/pom.xml, examples/demo-zk-books/pom.xml |
Parent / dependency version bumps to 26.5.1. |
platform/packages/*/package.json, platform/packages/*/package-lock.json, extensions/**/packages/*/package.json |
npm package version bumps to 26.5.1. |
extensions/entity-files/packages/simple-file-server/package.json + package-lock.json |
Lower engines to Node ≥18.17, downgrade file-type to ^20, lockfile resolves matching @tokenizer/inflate and fflate. |
extensions/entity-files/packages/simple-file-server/src/runtime/index.ts |
startServer now returns the SFSRuntime after listening. |
extensions/entity-files/packages/simple-file-server/src/cli/index.ts |
Print env/system info and post-start summary of buckets and identities; CLI version bump. |
extensions/entity-files/packages/simple-file-server/README.md |
Add Requirements, Embedded Usage, exports, env-var docs; update Node minimum. |
extensions/entity-files/packages/simple-file-server/examples/embedded/{package.json,index.js} |
New embedded-mode example. |
extensions/entity-files/sources/core/.../RemoteEntityFileStorage.java |
Use body(Resource.class) directly instead of InputStream + manual InputStreamResource wrap. |
examples/demo-zk-books/src/main/java/mybookstore/repositories/BookRepository.java |
Remove unused imports. |
Files not reviewed (3)
- extensions/entity-files/packages/simple-file-server/package-lock.json: Language not supported
- platform/packages/cli/package-lock.json: Language not supported
- platform/packages/sdk/package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.