Sso required liminal auth with playwright#203
Merged
nirmit-damania-dyno merged 6 commits intoMay 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the playwright package, used for authenticating your Benchling API connection with the user's credentials when SSO is optional or required on your tenant.
This flow will be used when
internal_api_admin_emailandinternal_api_admin_passwordare not set or when SSO is set to required on your tenant.When a liminal command is run and the above case is true, a playwright persistent browser window will open up to your Benchling tenant, and route the user to log into their SSO. After the user logs in, Liminal will be able to authenticate the Benching internal API connection. By default, playwright stores the user_data_dir in the root directory, so the user can setup a chrome profile as well and the next time they log in, the playwright browser can use the
user_data_dirproperty to allow automatic re-login (depending on how the SSO is setup). This behavior can be turned off in theBenchlingConnectionby settingplaywright_data_dirto None.