Skip to content

Sso required liminal auth with playwright#203

Merged
nirmit-damania-dyno merged 6 commits into
mainfrom
sso-required-liminal-auth-with-playwright
May 12, 2026
Merged

Sso required liminal auth with playwright#203
nirmit-damania-dyno merged 6 commits into
mainfrom
sso-required-liminal-auth-with-playwright

Conversation

@nirmit-damania-dyno
Copy link
Copy Markdown
Collaborator

@nirmit-damania-dyno nirmit-damania-dyno commented Apr 17, 2026

This PR adds the playwright package, used for authenticating your Benchling API connection with the user's credentials when SSO is optional or required on your tenant.

This flow will be used when internal_api_admin_email and internal_api_admin_password are not set or when SSO is set to required on your tenant.

When a liminal command is run and the above case is true, a playwright persistent browser window will open up to your Benchling tenant, and route the user to log into their SSO. After the user logs in, Liminal will be able to authenticate the Benching internal API connection. By default, playwright stores the user_data_dir in the root directory, so the user can setup a chrome profile as well and the next time they log in, the playwright browser can use the user_data_dir property to allow automatic re-login (depending on how the SSO is setup). This behavior can be turned off in the BenchlingConnection by setting playwright_data_dir to None.

@nirmit-damania-dyno nirmit-damania-dyno added semver:minor Added functionality in a backwards compatible manner (minor version bump) type:minor-enhancement New minor feature or request labels Apr 17, 2026
@nirmit-damania-dyno nirmit-damania-dyno merged commit fa840d0 into main May 12, 2026
4 checks passed
@nirmit-damania-dyno nirmit-damania-dyno deleted the sso-required-liminal-auth-with-playwright branch May 12, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor Added functionality in a backwards compatible manner (minor version bump) type:minor-enhancement New minor feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant