Skip to content

better error handling for autogenerate auth #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirmit-damania-dyno merged 1 commit into from
May 12, 2026
Merged

better error handling for autogenerate auth #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion liminal/connection/benchling_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ async def autogenerate_auth(
f"https://{benchling_tenant}.benchling.com/ext/saml/signin:begin",
allow_redirects=False,
)
if signin_page.status_code == 403:
if signin_page.status_code == 403 or signin_page.status_code == 400:
raise SSODisabledError(
f"admin_email and admin_password not provided when sso is turned off for Benchling tenant {benchling_tenant}."
)
Expand Down
Loading