Fix metadata cell auto-capitalization in sandboxes list#283
Draft
ben-fornefeld wants to merge 1 commit intomainfrom
Draft
Fix metadata cell auto-capitalization in sandboxes list#283ben-fornefeld wants to merge 1 commit intomainfrom
ben-fornefeld wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Ben Fornefeld <ben-fornefeld@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The metadata column in the sandboxes list table was displaying values in all uppercase (e.g.,
"SOURCE":"INFRA-ADMIN"instead of"source":"infra-admin"), which was confusing to users.Solution
Added
normal-caseclass to theJsonPopoverinMetadataCellto override the defaultuppercasestyling inherited from theButtonbase variant.Changes
src/features/dashboard/sandboxes/list/table-cells.tsxto addnormal-caseclass to metadata cell'sJsonPopoverTesting
The fix follows the same pattern already used in
TemplateCell(line 124), which also usesnormal-caseto prevent auto-capitalization.Fixes issue reported in Slack: metadata values should preserve their original casing and not be auto-capitalized.
Slack Thread