Skip to content

Fix and clean up get_tag tag lookup#16

Merged
arkamar merged 2 commits intomainfrom
fix/build-tag-regex
Mar 24, 2026
Merged

Fix and clean up get_tag tag lookup#16
arkamar merged 2 commits intomainfrom
fix/build-tag-regex

Conversation

@arkamar
Copy link
Copy Markdown
Contributor

@arkamar arkamar commented Mar 24, 2026

The unquoted \. was likely a typo for a literal dot, but it expands to . (any char), which silently matches the - delimiter after the version. Quote the patterns and use an explicit - to match the actual tag format.

Also replace the unnecessary subshell with a brace group.

The unquoted \. was likely a typo for a literal dot, but it expands to .
(any char), which silently matches the - delimiter after the version.
Quote the patterns and use an explicit - to match the actual tag format.
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 24, 2026

PR Summary

Low Risk
Low risk: only adjusts tag-matching logic in the build script, affecting which git tag is checked out for a given kernel version.

Overview
Fixes build.sh get_tag tag selection by quoting the grep patterns and matching an explicit - delimiter after the kernel version (instead of the previous loosely-escaped \.), ensuring the newest tag chosen corresponds to the intended microvm-kernel-${version}-...\.amzn2 or kernel-${version}-...\.amzn2 format.

Written by Cursor Bugbot for commit c4b33b5. This will update automatically on new commits. Configure here.

No need to fork a subshell for the grep fallback; a brace group works
the same way and avoids the overhead.
@arkamar arkamar changed the title fix: quote grep patterns in get_tag to match version delimiter correctly Fix and clean up get_tag tag lookup Mar 24, 2026
@jakubno jakubno self-assigned this Mar 24, 2026
@arkamar arkamar merged commit 8c5d52d into main Mar 24, 2026
6 checks passed
@arkamar arkamar deleted the fix/build-tag-regex branch March 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants