Skip to content

SDSTOR-22421: shard superblk backward compat for log-only shard refactor#438

Open
Hooper9973 wants to merge 1 commit into
eBay:dev/refactor_create_seal_shardfrom
Hooper9973:compatibiltiy_adaption
Open

SDSTOR-22421: shard superblk backward compat for log-only shard refactor#438
Hooper9973 wants to merge 1 commit into
eBay:dev/refactor_create_seal_shardfrom
Hooper9973:compatibiltiy_adaption

Conversation

@Hooper9973

Copy link
Copy Markdown
Contributor
  • Migrate v2 shard superblk (sb_version=0x02) to v3 on recovery; unify decode logic into decode_shard_sb() shared by raft-log path and on_shard_meta_blk_found

  • Decode old shard raft-log messages (v2 header_extn) on new code path; extend ResyncShardMetaData schema with sealed_lsn at end for old-buffer compat

  • Override get_blk_alloc_hint for CREATE/SEAL_SHARD to return committed-blk hint, skipping data-block allocation for log-only shard messages

- Migrate v2 shard superblk (sb_version=0x02) to v3 on recovery; unify decode
logic into decode_shard_sb() shared by raft-log path and on_shard_meta_blk_found

- Decode old shard raft-log messages (v2 header_extn) on new code path; extend
ResyncShardMetaData schema with sealed_lsn at end for old-buffer compat

- Override get_blk_alloc_hint for CREATE/SEAL_SHARD to return committed-blk hint,
skipping data-block allocation for log-only shard messages
@Hooper9973 Hooper9973 force-pushed the compatibiltiy_adaption branch from 746acd4 to a4ebeef Compare June 23, 2026 09:51
@Hooper9973

Copy link
Copy Markdown
Contributor Author

skip Check Version Update on branch : dev/refactor_create_seal_shard, the feature branch will merge into stable/v4.x with conan version 4.2.0

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 61.40351% with 22 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/refactor_create_seal_shard@46efb1e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_shard_manager.cpp 69.38% 13 Missing and 2 partials ⚠️
...ib/homestore_backend/replication_state_machine.cpp 0.00% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                        Coverage Diff                        @@
##             dev/refactor_create_seal_shard     #438   +/-   ##
=================================================================
  Coverage                                  ?   52.94%           
=================================================================
  Files                                     ?       36           
  Lines                                     ?     5349           
  Branches                                  ?      672           
=================================================================
  Hits                                      ?     2832           
  Misses                                    ?     2225           
  Partials                                  ?      292           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants