Fix pytest baseline geometry, NOBE, and NumPy issues#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common_tangent_radianraiseValueErrorfor invalid circle geometry instead of silently clamping impossible inputsNOBE_SHandNOBE_GA_SHreject empty graphs before indexing empty embedding resultsnp.float_has been removedSemantics
Kandtopkbehavior and adds an explicit empty-graph error.np.float64,np.float32, andnp.float16mappings unchanged, and falls back tonp.float64whennp.float_does not exist.Verification
git diff --checkblack --checkandisort --check-onlyon changed files62 passed, 20 skippedwithout lxml56 passedcommon_tangent_radianinputsNOBE_SHandNOBE_GA_SHnp.float64on NumPy 2.0Note
A local full
pytest easygraphrun was started but did not complete in a reasonable time on my machine, so I terminated it and relied on focused tests plus GitHub Actions for full-suite validation.