Skip to content

Test labels 2 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewSazonov wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Test labels 2 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ab9ee
Simplify label check using pre-built action
AndrewSazonov May 11, 2026
ff516b3
Simplify label check using pre-built action
AndrewSazonov May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 20 additions & 129 deletions .github/workflows/issues-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Verifies if the current issue has at least one real `[scope]` label and one
# real `[priority]` label. If either is missing, the workflow adds a reminder
# label with a warning emoji.
# Verifies if the current issue has at least one `[scope]` label and one
# `[priority]` label. If either is missing, the workflow adds a reminder label.

name: Issue labels check

Expand All @@ -20,130 +19,22 @@ jobs:
cancel-in-progress: true

steps:
- name: Checkout repository
uses: actions/checkout@v6

- name: Sync missing-label reminders
uses: ./.github/actions/github-script
- name: Ensure [scope] label
uses: Rindrics/expect-label-prefix@v1.2.1
with:
script: |
const fs = require('fs');

const issueNumber = context.issue.number;
const action = context.payload.action;
const changedLabel = context.payload.label?.name ?? null;
const labels = context.payload.issue.labels.map(({ name }) => name);
const requirements = [
{
prefix: '[scope] ',
reminder: '[scope] ⚠️ label needed',
},
{
prefix: '[priority] ',
reminder: '[priority] ⚠️ label needed',
},
];

const labelsToAdd = [];
const labelsToRemove = [];
const evaluations = [];

console.log(`::group::Issue label check for #${issueNumber}`);
console.log(`Event action: ${action}`);
if (changedLabel) {
console.log(`Event label: ${changedLabel}`);
}
console.log(
`Current labels: ${labels.length > 0 ? labels.join(', ') : '(none)'}`,
);

for (const { prefix, reminder } of requirements) {
const matchingRealLabels = labels.filter(
(name) => name.startsWith(prefix) && name !== reminder,
);
const hasRealLabel = matchingRealLabels.length > 0;
const hasReminderLabel = labels.includes(reminder);

evaluations.push({
prefix,
reminder,
matchingRealLabels,
hasReminderLabel,
});

if (hasRealLabel && hasReminderLabel) {
labelsToRemove.push(reminder);
} else if (!hasRealLabel && !hasReminderLabel) {
labelsToAdd.push(reminder);
}
}

for (const evaluation of evaluations) {
if (evaluation.matchingRealLabels.length > 0) {
console.log(
`Found required ${evaluation.prefix}label(s): ${evaluation.matchingRealLabels.join(', ')}`,
);
} else {
console.log(`Missing required ${evaluation.prefix}label.`);
}

if (evaluation.hasReminderLabel) {
console.log(`Reminder label already present: ${evaluation.reminder}`);
}
}

if (labelsToAdd.length > 0) {
console.log(`Adding reminder labels: ${labelsToAdd.join(', ')}`);
await github.rest.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
labels: labelsToAdd,
});
}

for (const name of labelsToRemove) {
console.log(`Removing reminder label: ${name}`);
await github.rest.issues.removeLabel({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
name,
});
}

if (labelsToAdd.length === 0 && labelsToRemove.length === 0) {
console.log('No label changes required.');
}

console.log('::endgroup::');

if (process.env.GITHUB_STEP_SUMMARY) {
const summaryLines = [
'### Issue Label Check',
`- Issue: #${issueNumber}`,
`- Event: ${action}`,
`- Trigger label: ${changedLabel ?? '(none)'}`,
`- Current labels: ${labels.length > 0 ? labels.join(', ') : '(none)'}`,
'',
'#### Requirement status',
...evaluations.map((evaluation) => {
const status =
evaluation.matchingRealLabels.length > 0
? `found ${evaluation.matchingRealLabels.join(', ')}`
: 'missing';
const reminder = evaluation.hasReminderLabel
? `reminder present: ${evaluation.reminder}`
: `reminder absent: ${evaluation.reminder}`;
return `- ${evaluation.prefix}: ${status}; ${reminder}`;
}),
'',
`- Labels to add: ${labelsToAdd.length > 0 ? labelsToAdd.join(', ') : '(none)'}`,
`- Labels to remove: ${labelsToRemove.length > 0 ? labelsToRemove.join(', ') : '(none)'}`,
];

fs.appendFileSync(
process.env.GITHUB_STEP_SUMMARY,
`${summaryLines.join('\n')}\n`,
);
}
repository_full_name: ${{ github.repository }}
token: ${{ github.token }}
label_prefix: '[scope]'
label_separator: ' '
add_label: 'true'
default_label: '[scope] ⚠️ label needed'

- name: Ensure [priority] label
uses: Rindrics/expect-label-prefix@v1.2.1
with:
repository_full_name: ${{ github.repository }}
token: ${{ github.token }}
label_prefix: '[priority]'
label_separator: ' '
add_label: 'true'
default_label: '[priority] ⚠️ label needed'
55 changes: 12 additions & 43 deletions .github/workflows/pr-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
# Verifies if a pull request has at least one label from a set of valid
# labels before it can be merged.
#
# NOTE:
# This workflow may be triggered twice in quick succession when a PR is
# created:
# 1) `opened` — when the pull request is initially created
# 2) `labeled` — if labels are added immediately after creation
# (e.g. by manual labeling, another workflow, or GitHub App).
#
# These are separate GitHub events, so two workflow runs can be started.

name: PR labels check

on:
Expand All @@ -22,35 +10,16 @@ permissions:
jobs:
check-labels:
runs-on: ubuntu-latest

steps:
- name: Check for valid labels
run: |
PR_LABELS=$(echo '${{ toJson(github.event.pull_request.labels.*.name) }}' | jq -r '.[]')

echo "Current PR labels: $PR_LABELS"
VALID_LABELS=(
"[bot] release"
"[scope] bug"
"[scope] documentation"
"[scope] enhancement"
"[scope] maintenance"
"[scope] significant"
)

found=false
for label in "${VALID_LABELS[@]}"; do
if echo "$PR_LABELS" | grep -Fxq "$label"; then
echo "✅ Found valid label: $label"
found=true
break
fi
done

if [ "$found" = false ]; then
echo "ERROR: PR must have at least one of the following labels:"
for label in "${VALID_LABELS[@]}"; do
echo " - $label"
done
exit 1
fi
- uses: mheap/github-action-required-labels@v5
with:
add_comment: true
mode: minimum
count: 1
labels: |
[bot] release
[scope] bug
[scope] documentation
[scope] enhancement
[scope] maintenance
[scope] significant
Loading