Feature/mct restore calib#222
Open
doc78 wants to merge 12 commits into
Open
Conversation
…ver the calibration results
…ver the calibration results II
…ver the calibration results III
…ver the calibration results IV
Collaborator
Author
|
@fuchsiger I see there are some code snipped used probably for test and commented or unused, but are still in the code. Can you please check them and clean up the code where possible? Furthermore, I see part of the code that seems related to MCT headwater and MCT confluences. This PR should be related to simulateCalibrationPoints and reduction of numerical instability (Chanq->ChanqAvg) only, while I will add later another PR including the MCT interface method as an additional optional module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for MCT to restore calibration points inflow and reduce numerical instabilities