fix: preserve JWK fields when adding key pair to DID document#1000
Merged
Conversation
When the serialized public key is already in JWK format, use it directly rather than round-tripping through a PublicKey, which drops extra JWK fields (alg, x5u, etc.). Falls back to the key parser registry for non-JWK formats such as PEM. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
paullatzelsperger
force-pushed
the
fix/774_preserve_jwk_fields
branch
from
651030c to
cd9a77a
Compare
paullatzelsperger
force-pushed
the
fix/774_preserve_jwk_fields
branch
from
cd9a77a to
b879e8c
Compare
wolf4ood
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicKeyJwkinstead of round-tripping throughPublicKey, which silently drops extra JWK fields (alg,x5u, etc.)KeyParserRegistryfor non-JWK formats (e.g. PEM), converting the resultingPublicKeyto a JWKif/elseinto aResult.recover()chain for clarityCloses #774