fix: reject duplicate credential issuance requests by holderPid#1001
Merged
paullatzelsperger merged 6 commits intoMay 28, 2026
Conversation
Both the issuer side (DcpIssuerServiceImpl) and the holder side (CredentialRequestManagerImpl) now return a CONFLICT result when a request with the same holderPid already exists for a given participant, preventing duplicate issuance processes from being created. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
paullatzelsperger
added
bug
paullatzelsperger
force-pushed
the
feat/reject_duplicate_issuance_requests
branch
from
fd58ca7 to
ba4ce2a
Compare
paullatzelsperger
force-pushed
the
feat/reject_duplicate_issuance_requests
branch
from
0236ddd to
b86f572
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jimmarino
approved these changes
May 28, 2026
wolf4ood
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on the holder side:
CredentialRequestManagerImpl.initiateRequestchecks for an existing holder credential request with the sameholderPidand returnsCONFLICTif found.on the issuer side:
DcpIssuerServiceImpl.createIssuanceProcessnow queries the issuance process store byholderPid+participantContextIdbefore creating a new process, returning aCONFLICTresult if one already exists.Further Remarks
IssuanceRequestedevent on the issuer side, because it didn't exist before.Closes #749