fix: map name and description claims#1002
Merged
paullatzelsperger merged 2 commits intoMay 28, 2026
Merged
Conversation
108958c to
8420d21
Compare
8420d21 to
1fa23b2
Compare
wolf4ood
approved these changes
May 28, 2026
65ac2da to
da5d789
Compare
da5d789 to
d178785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR properly maps the
nameanddescriptionclaims from theMappingDefinitioninto the credential if present.Why it does that
VCDM2.0 defines those properties, so they should be in the credential if available
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #701
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.