[3] Do not disable scrollable widgets when not editable#5
Open
peransin-obeo wants to merge 1 commit into
Open
Conversation
Not editable widget must not be disabled. Disable widget cannot be scrolled. User should be able to read and copy the content. Actions must still be driven by "is Enabled Expression". eclipse-eef#3 Change-Id: I46b47a1ade5b3472191e619f07aa1c4db93adaa9 Signed-off-by: Nicolas Peransin <nicolas.peransin@obeo.fr>
peransin-obeo
force-pushed
the
dev/scrollableReadonly
branch
from
61b76b3 to
7b89c5d
Compare
pcdavid
reviewed
May 27, 2026
| h4. Specifier-Visible Changes | ||
|
|
||
| * <span class="label label-info">Modified</span> The dynamic mappings will take into account all the "if" blocks with a valid predicate expression and not only the first one. | ||
| * <span class="label label-info">Modified</span> The dynamic mappings will take into account all the «if» blocks with a valid predicate expression and not only the first one. |
Contributor
There was a problem hiding this comment.
Is this change voluntary? Not sure it is "safe" in terms of potential encoding issues.
Contributor
Author
There was a problem hiding this comment.
in version version, Textile-to-html in mylyn was changing " into «. (at least into the html code « )
But last version (at least 2025/09) does not do it any more.
However most browser render '«' directly now.
So to keep the same text for user, I changed the textile text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not editable widget must not be disabled.
Disable widget cannot be scrolled.
User should be able to read and copy the content.
Actions must still be driven by "is Enabled Expression".
#3
How to test
Create a modeling Project with following VSM et Ecore model sample:
test_resources.zip
Select a EClass from Model explorer.
Some widgets are read-only state.
Expected: read-only texts and lists can be scrollable.
Expected: no popup dialog when selecting item of read-only lists but a dialog popup when selecting item of editable lists
Expected: read-only widgets have a different background from editable widgets.