Skip to content

Fix no-op test assertions and drop redundant eslint overrides #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tortmayr merged 1 commit into from
Jun 24, 2026
Merged

Fix no-op test assertions and drop redundant eslint overrides #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,4 @@ export default [
]
}
},
// Test file overrides
{
files: ['**/*.spec.{ts,tsx}'],
rules: {
'@typescript-eslint/no-unused-expressions': 'off',
'import-x/namespace': 'off'
}
}
];
8 changes: 4 additions & 4 deletions packages/server/src/common/actions/action-handler-registry.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ describe('Test ActionHandlerRegistry (only functionality that is not covered by

const result = registry.getAll();
expect(result).toHaveLength(4);
expect(result.includes(h1)).true;
expect(result.includes(h2)).true;
expect(result.includes(h3)).true;
expect(result.includes(h4)).true;
expect(result.includes(h1)).toBe(true);
expect(result.includes(h2)).toBe(true);
expect(result.includes(h3)).toBe(true);
expect(result.includes(h4)).toBe(true);
});

it('get - should return three handlers sorted by priority', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/common/actions/global-action-provider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ describe('test DefaultGlobalActionProvider', () => {
expect(result.size).toBe(1);
const resultServerActions = result.get(diagramType);
expect(resultServerActions).toBeDefined();
expect(serverActions.every(action => resultServerActions!.includes(action))).true;
expect(serverActions.every(action => resultServerActions!.includes(action))).toBe(true);
});
});
24 changes: 12 additions & 12 deletions packages/server/src/common/di/multi-bindings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('test implementations of MultiBinding', () => {
const binding = new MultiBinding('TestClass');
it('add - new binding', () => {
binding.add(TestClass1);
expect(binding.contains(TestClass1)).true;
expect(binding.contains(TestClass1)).toBe(true);

const result = binding.getAll();
expect(result.length).toBe(1);
Expand All @@ -48,9 +48,9 @@ describe('test implementations of MultiBinding', () => {
});

it('remove - existing binding', () => {
expect(binding.contains(TestClass1)).true;
expect(binding.contains(TestClass1)).toBe(true);
binding.remove(TestClass1);
expect(binding.contains(TestClass1)).false;
expect(binding.contains(TestClass1)).toBe(false);
expect(binding.getAll()).toHaveLength(0);
});

Expand All @@ -65,24 +65,24 @@ describe('test implementations of MultiBinding', () => {

const result = binding.getAll();
expect(result.length).toBe(2);
expect(result.includes(TestClass1)).true;
expect(result.includes(TestClass2)).true;
expect(result.includes(TestClass1)).toBe(true);
expect(result.includes(TestClass2)).toBe(true);
});

it('rebind- TestClass2 to TestClass3', () => {
binding.rebind(TestClass2, TestClass3);
const result = binding.getAll();
expect(result.length).toBe(2);
expect(result.includes(TestClass1)).true;
expect(result.includes(TestClass3)).true;
expect(result.includes(TestClass1)).toBe(true);
expect(result.includes(TestClass3)).toBe(true);
});

it('rebind- TestClass2 to TestClass3- should fail', () => {
binding.rebind(TestClass2, TestClass3);
const result = binding.getAll();
expect(result.length).toBe(2);
expect(result.includes(TestClass1)).true;
expect(result.includes(TestClass3)).true;
expect(result.includes(TestClass1)).toBe(true);
expect(result.includes(TestClass3)).toBe(true);
});

it('removeAll- TestClass1 & TestClass3', () => {
Expand Down Expand Up @@ -125,9 +125,9 @@ describe('test implementations of MultiBinding', () => {
testContainer.load(testModule);
const result = testContainer.get<string[]>(identifier);
expect(result).toHaveLength(3);
expect(result.includes(t1)).true;
expect(result.includes(t2)).true;
expect(result.includes(t3)).true;
expect(result.includes(t1)).toBe(true);
expect(result.includes(t2)).toBe(true);
expect(result.includes(t3)).toBe(true);
});
});
});
2 changes: 1 addition & 1 deletion packages/server/src/common/features/type-hints/request-type-hints-action-handler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('test RequestTypeHintsActionHandler', () => {
const result = await handler.execute(RequestTypeHintsAction.create());

expect(result).toHaveLength(1);
expect(SetTypeHintsAction.is(result[0])).true;
expect(SetTypeHintsAction.is(result[0])).toBe(true);
expect(result).toEqual([
{ edgeHints: [edgeTypeHint], kind: 'setTypeHints', shapeHints: [shapeTypeHint], responseId: '' } as SetTypeHintsAction
]);
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/common/session/client-session-manager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('test DefaultClientSessionManager', () => {
const sessionManager = container.resolve(DefaultClientSessionManager);

it('add listener', () => {
expect(sessionManager.addListener(testSessionListener, testSession.id)).true;
expect(sessionManager.addListener(testSessionListener, testSession.id)).toBe(true);
});

it('add create client session', () => {
Expand Down
22 changes: 11 additions & 11 deletions packages/server/src/common/utils/promise-queue.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,22 +88,22 @@ describe('test PromiseQueue', () => {
it('enqueue - one element', async () => {
const { state, promise } = newTestPromise(100);
state.onStart(() => {
expect(queue.isBusy).true;
expect(queue.isBusy).toBe(true);
});
const queEnd = queue.enqueue(promise);
expect(queue.isEmpty).true;
expect(queue.isEmpty).toBe(true);
await queEnd;
});

it('enqueue - two elements', async () => {
const p1 = newTestPromise(100);
p1.state.onStop(() => expect(p2.state.started).false);
p1.state.onStop(() => expect(p2.state.started).toBe(false));

const p2 = newTestPromise(100);

p2.state.onStart(() => {
expect(queue.isEmpty).true;
expect(p1.state.stopped).true;
expect(queue.isEmpty).toBe(true);
expect(p1.state.stopped).toBe(true);
});

queue.enqueue(p1.promise);
Expand All @@ -115,21 +115,21 @@ describe('test PromiseQueue', () => {
it('enqueue - three elements (first promise in queue has longest resolve time)', async () => {
const p1 = newTestPromise(300);
p1.state.onStop(() => {
expect(p2.state.started).false;
expect(p3.state.started).false;
expect(p2.state.started).toBe(false);
expect(p3.state.started).toBe(false);
});

const p2 = newTestPromise(200);
p2.state.onStart(() => {
expect(queue.size).toBe(1);
expect(p1.state.stopped).true;
expect(p3.state.started).false;
expect(p1.state.stopped).toBe(true);
expect(p3.state.started).toBe(false);
});

const p3 = newTestPromise(100);
p3.state.onStart(() => {
expect(queue.isEmpty).true;
expect(p2.state.stopped).true;
expect(queue.isEmpty).toBe(true);
expect(p2.state.stopped).toBe(true);
});

queue.enqueue(p1.promise);
Expand Down
58 changes: 29 additions & 29 deletions packages/server/src/common/utils/registry.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,52 +28,52 @@ describe('Test Registry', () => {
it('register - with new key-value pair', () => {
const key = 'key';
const value = 'value';
expect(registry.register(key, value)).true;
expect(registry.register(key, value)).toBe(true);
expect(registry.get(key), value);
});

it('register - with key-value pair with a already registered key', () => {
// Setup
const key = 'key';
const value = 'value';
expect(registry.register(key, value)).true;
expect(registry.register(key, value)).toBe(true);
// Test execution
expect(registry.register(key, 'newValue')).false;
expect(registry.register(key, 'newValue')).toBe(false);
expect(registry.get(key), value);
});

it('deregister - with registered key', () => {
// Setup
const key = 'key';
const value = 'value';
expect(registry.register(key, value)).true;
expect(registry.register(key, value)).toBe(true);
// Test execution
expect(registry.deregister(key)).true;
expect(registry.deregister(key)).toBe(true);
expect(registry.get(key), undefined);
});

it('deregister - with unregistered key', () => {
expect(registry.deregister('unregisteredKey')).false;
expect(registry.deregister('unregisteredKey')).toBe(false);
});

it('haskey - with registered key', () => {
// Setup
const key = 'key';
const value = 'value';
expect(registry.register(key, value)).true;
expect(registry.register(key, value)).toBe(true);
// Test execution
expect(registry.hasKey(key)).true;
expect(registry.hasKey(key)).toBe(true);
});

it('haskey - with unregistered key', () => {
expect(registry.deregister('unregisteredKey')).false;
expect(registry.deregister('unregisteredKey')).toBe(false);
});

it('get - with registered key', () => {
// Setup
const key = 'key';
const value = 'value';
expect(registry.register(key, value)).true;
expect(registry.register(key, value)).toBe(true);
// Test execution
expect(registry.get(key), value);
});
Expand All @@ -93,9 +93,9 @@ describe('Test Registry', () => {
// Test execution
const result = registry.getAll();
expect(result).toHaveLength(3);
expect(result.includes(e1.value)).true;
expect(result.includes(e2.value)).true;
expect(result.includes(e3.value)).true;
expect(result.includes(e1.value)).toBe(true);
expect(result.includes(e2.value)).toBe(true);
expect(result.includes(e3.value)).toBe(true);
});

it('keys - should return three keys', () => {
Expand All @@ -109,9 +109,9 @@ describe('Test Registry', () => {
// Test execution
const result = registry.keys();
expect(result).toHaveLength(3);
expect(result.includes(e1.key)).true;
expect(result.includes(e2.key)).true;
expect(result.includes(e3.key)).true;
expect(result.includes(e1.key)).toBe(true);
expect(result.includes(e2.key)).toBe(true);
expect(result.includes(e3.key)).toBe(true);
});
});

Expand All @@ -133,8 +133,8 @@ describe('Test MapMultiRegistry', () => {
const resultValue = multiRegistry.get(e1.key);
expect(resultValue).toBeDefined();
expect(resultValue!.length).toBe(2);
expect(resultValue!.includes(e1.value)).true;
expect(resultValue!.includes(e2.value)).true;
expect(resultValue!.includes(e1.value)).toBe(true);
expect(resultValue!.includes(e2.value)).toBe(true);
});

it('deregister - with registered key', () => {
Expand All @@ -144,14 +144,14 @@ describe('Test MapMultiRegistry', () => {
multiRegistry.register(key, existingValue[0]);
multiRegistry.register(key, existingValue[1]);
// Test execution
expect(multiRegistry.deregister(key, existingValue[1])).true;
expect(multiRegistry.deregister(key, existingValue[1])).toBe(true);
const result = multiRegistry.get(key);
expect(result.length).toBe(1);
expect(result[0], existingValue[0]);
});

it('deregister - with unregistered key', () => {
expect(multiRegistry.deregister('unregisteredKey', 'someValue')).false;
expect(multiRegistry.deregister('unregisteredKey', 'someValue')).toBe(false);
});

it('deregisterAll - with registered key', () => {
Expand All @@ -160,12 +160,12 @@ describe('Test MapMultiRegistry', () => {
const existingValue = ['value', 'value2'];
multiRegistry.register(key, existingValue[0]);
multiRegistry.register(key, existingValue[1]);
expect(multiRegistry.deregisterAll(key)).true;
expect(multiRegistry.deregisterAll(key)).toBe(true);
expect(multiRegistry.get(key)).toHaveLength(0);
});

it('deregisterAll - with unregistered key', () => {
expect(multiRegistry.deregisterAll('unregisteredKey')).false;
expect(multiRegistry.deregisterAll('unregisteredKey')).toBe(false);
});

it('haskey - with registered key', () => {
Expand All @@ -174,11 +174,11 @@ describe('Test MapMultiRegistry', () => {
const existingValue = 'value';
multiRegistry.register(key, existingValue);
// Test execution
expect(multiRegistry.hasKey(key)).true;
expect(multiRegistry.hasKey(key)).toBe(true);
});

it('haskey - with unregistered key', () => {
expect(multiRegistry.hasKey('unregisteredKey')).false;
expect(multiRegistry.hasKey('unregisteredKey')).toBe(false);
});

it('get - with registered key', () => {
Expand All @@ -188,7 +188,7 @@ describe('Test MapMultiRegistry', () => {
multiRegistry.register(key, existingValue);
// Test execution
expect(multiRegistry.get(key).length).toBe(1);
expect(multiRegistry.get(key).includes(existingValue)).true;
expect(multiRegistry.get(key).includes(existingValue)).toBe(true);
});

it('get - with unregistered key', () => {
Expand All @@ -205,8 +205,8 @@ describe('Test MapMultiRegistry', () => {
// Test execution
const result = multiRegistry.getAll();
expect(result).toHaveLength(3);
expect(e1.value.every(v => result.includes(v))).true;
expect(e2.value.every(v => result.includes(v))).true;
expect(e1.value.every(v => result.includes(v))).toBe(true);
expect(e2.value.every(v => result.includes(v))).toBe(true);
});

it('keys', () => {
Expand All @@ -219,7 +219,7 @@ describe('Test MapMultiRegistry', () => {
// Test execution
const result = multiRegistry.keys();
expect(result.length).toBe(2);
expect(result.includes(e1.key)).true;
expect(result.includes(e2.key)).true;
expect(result.includes(e1.key)).toBe(true);
expect(result.includes(e2.key)).toBe(true);
});
});
4 changes: 2 additions & 2 deletions packages/server/src/node/launch/socket-cli-parser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ describe('test createCliParser', () => {

it('parse - --no-consoleLog', () => {
const result = parser.parse([...argv, '--no-consoleLog']);
expect(result.consoleLog).false;
expect(result.consoleLog).toBe(false);
});

it('parse - --fileLog', () => {
const result = parser.parse([...argv, '--fileLog']);
expect(result.fileLog).true;
expect(result.fileLog).toBe(true);
});

it('parse - custom host name', () => {
Expand Down
Loading