fix: replace deprecated license classifier with SPDX expression (#46)#60
Open
aki1770-del wants to merge 1 commit into
Open
fix: replace deprecated license classifier with SPDX expression (#46)#60aki1770-del wants to merge 1 commit into
aki1770-del wants to merge 1 commit into
Conversation
…pse-kuksa#46) setuptools deprecated 'License ::' trove classifiers in favor of a SPDX license expression. Drop the classifier and declare 'license = Apache-2.0' in setup.cfg [metadata]; bump the build requirement to setuptools>=77, which is where PEP 639 SPDX-expression support landed (the older >=42 pin would treat the value as free-text and not clear the warning). Fixes eclipse-kuksa#46. Signed-off-by: Akihiko Komada <aki1770@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
Per @SebastianSchildt (#46): "Feel free to give fixing this a try. If this can be done in a contained way, and changing the config + bumping setuptools does the trick without bad side effects, I am all for it."
Problem
setuptoolsdeprecated theLicense ::trove classifiers in favour of a SPDX license expression, so the build emits:Fix (contained, 2 lines)
kuksa-client/setup.cfg— drop theLicense :: OSI Approved :: Apache Software Licenseclassifier; addlicense = Apache-2.0(SPDX expression) under[metadata].kuksa-client/pyproject.toml— bump the build requirementsetuptools>=42→setuptools>=77. PEP 639 SPDX-expression support landed in setuptools 77; without the bump an older setuptools would treatApache-2.0as free-text and the warning wouldn't clear.license_files = LICENSEis unchanged.Verification (no bad side effects)
Built sdist + wheel with setuptools 82 (
python -m build):SetuptoolsDeprecationWarning: License classifiers are deprecatedpresent.METADATA(Metadata-Version 2.4):License: Apache-2.0,License-File: LICENSE, and noClassifier: License ::line remaining.