chore: migrate to new cicd-workflows with custom pre-commit config#28
Draft
alexmohr wants to merge 1 commit into
Draft
chore: migrate to new cicd-workflows with custom pre-commit config#28alexmohr wants to merge 1 commit into
alexmohr wants to merge 1 commit into
Conversation
- Add .pre-commit-config.yaml with all required hooks (check-yaml, check-toml, check-json, yamlfmt, markdownlint, ruff, gitleaks, shellcheck, conventional-pre-commit, reuse-annotate, cargo-fmt, clippy, validate-cargo-lints, check-hooks) - Add canonical .yamlfmt, .markdownlint.yaml, .rustfmt.toml from cicd - Remove old rustfmt.toml (replaced by canonical .rustfmt.toml) - Update pre-commit.yaml to use composite action with rust-toolchain input - Update pr-checks.yml to point to feat/pre-commit-hook-args-config branch
Author
|
@arvindr19 I'm currently going around in OpenSOVD and aligning our pre commit validations. The changes in here should be pretty minimal as you already use most of the things. Changes in core are a bit bigger because I am also trying to align the rust format settings. Will be part of the next architecture agenda eclipse-opensovd/opensovd#8 (comment) please join if you find the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pre-commit-config.yamlwith all required hooks (formatting, linting, security, license headers, Rust tooling).yamlfmt,.markdownlint.yaml,.rustfmt.toml) from cicd-workflows shared-configrustfmt.toml(replaced by canonical.rustfmt.toml)pre-commit.yamlworkflow to use the composite action withrust-toolchaininputpr-checks.ymlSHA pins tofeat/pre-commit-hook-args-configbranchChecklist
Related
Notes for Reviewers
The cicd-workflows pin points to the
feat/pre-commit-hook-args-configbranch. Once eclipse-opensovd/cicd-workflows#39 merges to main, the SHA pin should be updated to the merge commit on main.Alexander Mohr alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information