Doip server initial code by VinaykumarRS1995 · Pull Request #4 · eclipse-opensovd/uds2sovd-proxy

VinaykumarRS1995 · 2026-02-25T12:51:36Z

Summary

This PR implements a DoIP (Diagnostic over Internet Protocol) server that allows automotive diagnostic tools to communicate with ECUs over TCP/UDP networks, following the ISO 13400-2:2019 standard. The implementation includes message parsing, session management, and a pluggable interface for connecting different UDS diagnostic backends.

All code review feedback has been addressed, including proper license headers, code duplication fixes.

Checklist

I have tested my changes locally
I have added or updated documentation
I have linked related issues or discussions
I have added or updated tests

arvindr19 · 2026-02-26T04:19:44Z

Is this code supposed to build? When I ran cargo check and cargo build, I encountered some errors. IMO, code should build successfully.

VinaykumarRS1995 · 2026-02-26T09:43:47Z

Is this code supposed to build? When I ran cargo check and cargo build, I encountered some errors. IMO, code should build successfully.

build is successful is now.

arvindr19 · 2026-02-26T10:10:36Z

fix minor formatting inconsistencies
toml = "0.9.11+spec-1.1.0" causing warning, why not toml = "0.9" instead?

arvindr19

Only header_parser.rs has any tracing at all. Every other file has no tracing.

darkwisebear

I didn't go into details yet, but from what I see there are some general things that need cleanup before I will do that:

Consolidate error types and use thiserror everywhere.
Introduce a trait for message types and use everywhere
Deduplicate common parsing code

darkwisebear · 2026-02-26T20:37:18Z

+        let eid: [u8; 6] = payload
+            .get(..Self::LEN)
+            .and_then(|s| s.try_into().ok())
+            .ok_or(Error::PayloadTooShort {
+                expected: Self::LEN,
+                actual: payload.len(),
+            })?;


Such code could be factored out, as there is similar code also in alive_check.rs. I think there should be a submodule messages with common definitions and then types for each message.

arvindr19 · 2026-03-02T06:23:08Z

Please run cargo fmt --check; it currently fails. Once the CI workflow PR is merged, this PR will need to be reworked, so it’s better to fix it beforehand.

lh-sag

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?

Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

lh-sag · 2026-03-04T06:45:54Z

+    fn parse_vin(s: &str) -> anyhow::Result<[u8; 17]> {
+        let bytes = s.as_bytes();
+        if bytes.len() != 17 {
+            anyhow::bail!("VIN must be exactly 17 characters");


Optional: I would rather return a proper error type than a string.

alexmohr · 2026-03-04T10:16:43Z

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?
* https://github.com/samp-reston/doip-definitions

* https://github.com/samp-reston/doip-codec

* https://github.com/samp-reston/doip-sockets

* https://github.com/samp-reston/doip-server
Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

We're only using codec and definitions in the CDA as we had some issues with sockets. But using codecs and definitions would already prevent re-implemeting some things here. The sockets connections can be re-used from CDA. Currently both doip libraries we use are forked by @theswiftfox. I believe it would be a good idea to use her fork as a base to officially provide an eclipse fork we use in all of our projects.

floroks · 2026-03-05T08:26:34Z

I believe it would be a good idea to use her fork as a base to officially provide an eclipse fork we use in all of our projects.

As we've also run into some issues with the original code, I think we need should fork them into the eclipse-opensovd repo, so we can adapt them quickly to our needs. I'll put it on the agenda for the next architecture board.

stmuench · 2026-03-06T08:44:28Z

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?

https://github.com/samp-reston/doip-definitions

https://github.com/samp-reston/doip-codec

https://github.com/samp-reston/doip-sockets

https://github.com/samp-reston/doip-server

Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

@lh-sag personally, I would be reluctant with using creates where there is only exactly one maintainer and no updates in the github repo since quite some time. This is risk in my eyes. What's your opinion on this situation?

VinaykumarRS1995 · 2026-03-10T09:55:43Z

Just had a brief look at the PR.

@VinaykumarRS1995 did you had a chance to evaluate any of these crates to ease development?

https://github.com/samp-reston/doip-definitions

https://github.com/samp-reston/doip-codec

https://github.com/samp-reston/doip-sockets

https://github.com/samp-reston/doip-server

Adding @alexmohr and @theswiftfox to share their experience with some of the crates above.

The consideration for integrating DoIP crates is tracked in #9 - will revisit once they are officially part of the OpenSOVD project. Not blocking this PR.

darkwisebear · 2026-03-03T13:31:39Z

+pub struct PositiveAck {
+    source_address: u16,
+    target_address: u16,
+    ack_code: AckCode,


That seems redundant. The pure existence of the instance indicates success.

Merged PositiveAck and NegativeAck into a single DiagnosticAck with result: AckResult (Positive | Negative(NackCode)).

bharatGoswami8 · 2026-03-17T05:55:30Z

+    /// Override this to enable pre-allocated buffers in [`to_bytes`], avoiding
+    /// incremental `BytesMut` reallocations for large messages.
+    fn serialized_len(&self) -> Option<usize> {
+        None


Returning None in the default implementation doesn’t seem correct to me. If a user calls this method on a type that doesn’t override it, they still get a valid Option, which may be misleading.

Done, Changes are pushed

bharatGoswami8 · 2026-03-17T06:00:00Z

+        })
+}
+
+// Re-export core types and constants for convenient access.


Consider keeping the header at the start of the file. If it’s user-facing, re-exporting it via lib.rs could be a good option.

Done. Moved all pub use re-exports to top mod.rs

lh-sag · 2026-03-18T07:47:35Z

In general I would like to see structured logs instead of strings. This is done in CDA and Core. Can you please apply this to your logs?

debug!("Session {} routing activated: tester_address=0x{:04X}", self.id, tester_address);

With structured logging (simplified for demonstration purpose):

debug!(session = self.id, tester_address, "routing activated");

- Consolidate errors into DoipError; add TryFrom<u8> on all enums - Strongly type activation_type field (ActivationType, not u8) - Add DoipParseable / DoipSerializable traits + DoipPayload dispatch enum - Override serialized_len() on all impls; fix array size magic numbers - Make ParseError pub(crate); add serde(default), tracing

- Split header_parser.rs into header.rs + codec.rs - Merge ParseError into DoipError (single error type) - Add parse_fixed_slice helper, remove duplicated parse patterns - Add DoipParseable / DoipSerializable traits - Make struct fields private, add public getters - Set default-features = false on all dependencies - Trim tokio features to io-util only - Remove dead test-handlers feature from Cargo.toml

Replace std::result::Result<_, DoipError> with crate::DoipResult across all files; add pub use error::DoipResult in lib.rs - remove redundant AckCode enum - remove redundant ack_code field from PositiveAck - merge PositiveAck + NegativeAck into DiagnosticAck with AckResult enum (Positive | Negative(NackCode))

- structured tracing logging; error! for parse failures - rename DoipResult → Result - single RwLock<SessionManagerInner> + AtomicU64 - merge DiagnosticAck + AckResult; remove AckCode - doc comments on all public API items

… toml

arvindr19

LGTM :)

bharatGoswami8 · 2026-05-08T04:07:01Z

+/// a tester is still connected.
+///
+/// This message carries no payload (zero-length body per ISO 13400-2:2019 §7.6).
+#[derive(Debug, Clone, PartialEq, Eq, Default)]


why this type has clone ?

DoipPayoad derives close and wraps this type so clone is required

bharatGoswami8 · 2026-05-08T04:09:14Z

+    /// Alive Check Request carries no payload bytes per ISO 13400-2;
+    /// nothing is written to the buffer by design.
+    fn write_to(&self, _buf: &mut BytesMut) {
+        // Intentionally empty: Alive Check Request has a zero-length payload.


maybe lets put some warn log so if someone called by mistake then with logging can be identified for alive check no write support.

Agree. Updated

bharatGoswami8 · 2026-05-08T04:25:28Z

+    fn decode(
+        &mut self,
+        src: &mut BytesMut,
+    ) -> std::result::Result<Option<Self::Item>, Self::Error> {


you have alias for result in error file, why can't use same.

Added the comment

bharatGoswami8 · 2026-05-08T04:59:26Z

+        })
+    }
+
+    fn parse_vin(s: &str) -> crate::Result<[u8; 17]> {


Its VIN length -> using VIN_LEN=17

bharatGoswami8 · 2026-05-08T05:01:33Z

+
+/// Session states per ISO 13400-2:2019 connection lifecycle
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum SessionState {


why this type is pub

Fixed — changed to pub(crate). External callers use is_routing_active() instead; no need to expose the internal state machine variants publicly.

bharatGoswami8 · 2026-05-08T07:28:45Z

+
+    /// The logical source address of the tester
+    #[must_use]
+    pub fn source_address(&self) -> u16 {


name of function should not be same as field name, use may be get

bharatGoswami8

@VinaykumarRS1995 ,
Here is some general feedback to address:

Enhance the PR summary with more detail and include sequence or class diagrams.
Review the visibility of all APIs and types and restrict the scope of those not meant for external use.
Evaluate the use of directly imported free functions.
check exported types using derive macros (e.g., Default, Clone) to ensure they are necessary.
Use interface defined Result instead of using std::Result or crate::Result.
Ensure test-related functions are not public and verify their access levels.
Refine type naming to more accurately reflect their specific functionality.

- Narrow internal API visibility: DoipParseable→pub(crate), Session::new/activate_routing/connection_state→pub(crate), DoipMessage::with_raw_payload_type→pub(crate), SessionState→pub(crate); external callers use is_routing_active() - Rename protocol enums for domain clarity: NackCode->DiagnosticNackCode, AckResult->DiagnosticAckResult, ResponseCode->ActivationResponseCode, SyncStatus->GidSyncStatus - Restore warn!() in AliveCheckRequest::write_to - Promote VIN_LEN to module-level pub(crate) const (ISO 3779 ref, removes magic 17 literals from struct field, DEFAULT_VIN, parse_vin) - Add comment in codec.rs explaining io::Result vs crate::Result - Add Copy derive to AliveCheckRequest - Add RoutingActivationResponse::with_oem_specific() builder - Consistent crate::Result alias in mod.rs, payload.rs, config.rs - Add PlantUML architecture diagrams (classDia.puml, seq.puml, flowchart.puml)

bharatGoswami8

@VinaykumarRS1995
Please check for following points-

check exported types using derive macros (Debug, Clone, PartialEq, Eq) to ensure they are necessary, if it is for test then we need remove from type level.
check if test related function can be implemented in test module.
Add the svg for design diagram.
Add design / sequence diagram for interface / public APIs

bharatGoswami8 · 2026-05-11T15:41:10Z

 /// Payload: SA(2) + TA(2) + code(1) + optional `previous_diag_data`
+///
+/// `Clone` is derived because [`DoipPayload`](super::payload::DoipPayload) wraps this type and itself derives `Clone`.
 #[derive(Debug, Clone, PartialEq, Eq)]


Is making DoipPayload clonable actually necessary ?

Checke Payload is not cloned in codebase - Removed

bharatGoswami8 · 2026-05-11T15:42:33Z

-pub struct Request;
+///
+/// `Clone` is derived because [`DoipPayload`](super::payload::DoipPayload) wraps this type and itself derives `Clone`.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]


Is making DoipPayload clonable actually necessary

bharatGoswami8 · 2026-05-11T15:46:10Z

+    /// The logical address of the tester that sent this response.
    #[must_use]
-    pub fn source_address(&self) -> u16 {
+    pub fn tester_address(&self) -> u16 {


Change to fn get_address(&self) -> u16

suggestion: if such impl is required for test only, we could impl such member functions inside mod tests {}

Doen. Renamed get_address() moved to tests

bharatGoswami8 · 2026-05-11T15:48:55Z

    source_address: u16,
    target_address: u16,
-    result: AckResult,
+    result: DiagnosticAckResult,


you already have struct name DiagnosticAck so no need to mention on field name.

Done. DiagnosticAckResult -> AckResult -- removed prefix

bharatGoswami8 · 2026-05-11T15:52:02Z

    /// Panics if `payload.len()` exceeds `u32::MAX`.
    #[cfg(test)]
-    pub fn with_raw_payload_type(payload_type: u16, payload: Bytes) -> Self {
+    pub(crate) fn with_raw_payload_type(payload_type: u16, payload: Bytes) -> Self {


can't we create impl for this type on test module and implement test related function rather then using #cfg(test) on regular impl block.

Done. No #cfg(test) on the regular impl blocks

bharatGoswami8 · 2026-05-11T15:54:25Z

 // ============================================================================

 #[cfg(test)]
 #[allow(clippy::indexing_slicing)]


Please add justification comment for clippy supression.

Done. Added

rpreddyhv · 2026-05-12T02:47:29Z

@@ -38,6 +42,9 @@ impl DoipSerializable for Request {
    /// nothing is written to the buffer by design.


suggestion: if AliveCheckRequest carries no payload and nothing has to written to the buffer then there shouldn't be any write_to implemented for it in first place.

Agree. Updated

rpreddyhv · 2026-05-12T02:48:59Z

+    /// The logical address of the tester that sent this response.
    #[must_use]
-    pub fn source_address(&self) -> u16 {
+    pub fn tester_address(&self) -> u16 {


suggestion: if such impl is required for test only, we could impl such member functions inside mod tests {}

rpreddyhv · 2026-05-12T02:51:27Z

    /// Create a new Alive Check Response with the given tester source address.
    #[must_use]
    pub fn new(source_address: u16) -> Self {
        Self { source_address }


question: I don't see any usage of source_address. Do we plan to add some validation in future on the source_address to verify if we received such response for a request that we sent?

Its intentionally retained. Will be used in follow up PRs

rpreddyhv · 2026-05-12T03:04:55Z

issue: Folder & file naming is not consistent with rust naming convention and rest of the changes in this PR.

rpreddyhv · 2026-05-12T03:06:08Z

suggestion: File name can be sequence.puml or if it covers only specific sequence name it accordingly.

rpreddyhv · 2026-05-12T03:08:38Z

    Io(#[from] io::Error),

-    #[error("Configuration error: {0}")]
+    #[error("configuration error: {0}")]


question: Is this string case sensitive? How does it make a difference changing "Configuration" to "configuration"? (for the other instance as well in this file)

The strings are not case-sensitive for matching purposes—the change is a style convention.

rpreddyhv · 2026-05-12T03:10:48Z

-    use crate::doip::diagnostic_message::NackCode as DiagnosticNackCode;
-    use crate::doip::{
-        header::GenericNackCode, routing_activation::ResponseCode as RoutingActivationCode,
-    };
-
-    /// UDS Negative Response Codes (ISO 14229-1:2020)
-    #[derive(Debug, Clone, Copy, PartialEq, Eq)]
-    #[repr(u8)]
-    enum UdsNrc {
-        GeneralReject = 0x10,
-        ServiceNotSupported = 0x11,
-        SubFunctionNotSupported = 0x12,
-        IncorrectMessageLength = 0x13,
-        BusyRepeatRequest = 0x21,
-        ConditionsNotCorrect = 0x22,
-        RequestSequenceError = 0x24,
-        RequestOutOfRange = 0x31,
-        SecurityAccessDenied = 0x33,
-        InvalidKey = 0x35,
-        ExceededNumberOfAttempts = 0x36,
-        RequiredTimeDelayNotExpired = 0x37,
-        ResponsePending = 0x78,
-        ServiceNotSupportedInActiveSession = 0x7F,
-    }
-
-    impl UdsNrc {
-        #[must_use]
-        const fn as_u8(self) -> u8 {
-            self as u8
-        }
-    }


question: What was the reason for adding this enum, impl block here earlier and removing it now? (And also, the tests)

UdsNrc was scaffolded in error.rs as a placeholder during early development. It was removed

rpreddyhv · 2026-05-12T03:17:04Z

+    #[test]
+    fn uds_nrc_wire_values() {
+        // Verify UDS NRC codes (ISO 14229-1:2020 Table A.1) match their wire values.
+        let cases: &[(u8, u8)] = &[
+            (0x10, 0x10), // GeneralReject
+            (0x11, 0x11), // ServiceNotSupported
+            (0x12, 0x12), // SubFunctionNotSupported
+            (0x13, 0x13), // IncorrectMessageLength
+            (0x21, 0x21), // BusyRepeatRequest
+            (0x22, 0x22), // ConditionsNotCorrect
+            (0x24, 0x24), // RequestSequenceError
+            (0x31, 0x31), // RequestOutOfRange
+            (0x33, 0x33), // SecurityAccessDenied
+            (0x35, 0x35), // InvalidKey
+            (0x36, 0x36), // ExceededNumberOfAttempts
+            (0x37, 0x37), // RequiredTimeDelayNotExpired
+            (0x78, 0x78), // ResponsePending
+            (0x7F, 0x7F), // ServiceNotSupportedInActiveSession
+        ];
+        for &(nrc, expected) in cases {
+            assert_eq!(nrc, expected);
+        }


question: What is the use of such test?

Agree- removed

rpreddyhv · 2026-05-12T03:22:10Z

question: What is u64 in these 2 HashMaps? If it is for SessionId, then there must be a NewType for it.

Agree - newType is introduced.

bharatGoswami8

Design suggestion(P1): As per the doip-server/Doc/sequence.puml my suggestion is create a type connectionBuilder and once connection is successful return another type DoipHandler with this type user can call RoutingActivationRequest , DiagnosticMessage APIs and this should support disconnection API as well, when user call disconnect , will return connectionBuilder if required for connection request again or cache some info like IP, Port address.
So basically it is based on builder pattern.

Note- suggested naming is just for example.

bharatGoswami8 · 2026-05-13T03:21:05Z

+}
+
+participant "Tester\n(TCP Client)" as T
+participant "DoipCodec\ncodec.rs" as C


Design(P0) : if this is interface crate then name of file not correct, please create another file which do the interface work.

yes. It is updated

bharatGoswami8 · 2026-05-13T03:23:02Z

+T -> C : TCP connect
+C -> SM : create_session(peer_addr)
+SM -> S ** : Session::new(id, addr)\nstate=Connected
+


Design(P0) : i don't see any type return to user if not then in that case without connection user can call Routing Activation methods / APIs without connection or session creation.

yes. It is updated

bharatGoswami8 · 2026-05-13T03:25:44Z

+H -> SM : remove_session(id)
+SM -> S !! : Session dropped\nstate=Closed
+
+@enduml


new line missing at the end.

bharatGoswami8 · 2026-05-13T03:28:01Z

+
+== Disconnection ==
+
+T ->x C : TCP close / timeout


Disconnection part is not fully cleared, who is requesting for disconnection i guess it should be user ?

- Remove DoipSerializable impl + test from AliveCheckRequest - Rename DiagnosticAckResult -> AckResult - Move test-only helpers into mod tests (header, alive_check) - Add #[non_exhaustive] to DoipError - Make Session pub(crate); add SessionId newtype - Rename Doc/ -> doc/; update all diagrams + regenerate SVGs - Clarify sequence.puml: no user handle on connect, disconnection paths

arvindr19 · 2026-05-20T07:31:31Z

@@ -0,0 +1,464 @@
+@startuml ClassDiagram


file names in the doc/ folder are too generic.

bharatGoswami8 · 2026-05-20T11:48:46Z

Design suggestion(P1): As per the doip-server/Doc/sequence.puml my suggestion is create a type connectionBuilder and once connection is successful return another type DoipHandler with this type user can call RoutingActivationRequest , DiagnosticMessage APIs and this should support disconnection API as well, when user call disconnect , will return connectionBuilder if required for connection request again or cache some info like IP, Port address. So basically it is based on builder pattern.

Note- suggested naming is just for example.

@VinaykumarRS1995, I do not see the design related changes on latest commit, I can only see the flow diagram update, please check if you miss those files to push,

VinaykumarRS1995 force-pushed the doip-server-initial branch 2 times, most recently from a11f029 to c674ff3 Compare February 26, 2026 09:40

arvindr19 reviewed Feb 26, 2026

View reviewed changes

Comment thread src/doip/diagnostic_message.rs Outdated

arvindr19 reviewed Feb 26, 2026

View reviewed changes

Comment thread doip-server/src/doip/header.rs

Comment thread doip-server/src/doip/routing_activation.rs Outdated

Comment thread doip-server/src/doip/diagnostic_message.rs Outdated

Comment thread src/doip/header_parser.rs Outdated

darkwisebear reviewed Feb 26, 2026

View reviewed changes

arvindr19 reviewed Feb 27, 2026

View reviewed changes

Comment thread src/doip/alive_check.rs Outdated

VinaykumarRS1995 force-pushed the doip-server-initial branch 2 times, most recently from 81e9ff5 to 9fa0c6e Compare March 2, 2026 05:49

VinaykumarRS1995 marked this pull request as ready for review March 2, 2026 09:23

VinaykumarRS1995 requested a review from darkwisebear March 2, 2026 09:23

lh-sag requested review from a team and removed request for darkwisebear March 4, 2026 06:32

lh-sag reviewed Mar 4, 2026

View reviewed changes

VinaykumarRS1995 requested a review from lh-sag March 11, 2026 05:18

darkwisebear reviewed Mar 12, 2026

View reviewed changes

VinaykumarRS1995 requested a review from darkwisebear March 13, 2026 02:24

VinaykumarRS1995 force-pushed the doip-server-initial branch from c8ccfbf to 0c12dc0 Compare March 17, 2026 05:39

bharatGoswami8 reviewed Mar 17, 2026

View reviewed changes

lh-sag reviewed Mar 18, 2026

View reviewed changes

Comment thread doip-server/src/server/session.rs Outdated

lh-sag reviewed Mar 18, 2026

View reviewed changes

Comment thread doip-server/src/error.rs Outdated

lh-sag reviewed Mar 18, 2026

View reviewed changes

Comment thread src/doip/hearder_parser.rs Outdated

VinaykumarRS1995 and others added 11 commits April 27, 2026 06:02

feat(uds): add UdsHandler trait for pluggable backends

2208cbb

style: apply cargo fmt

b12490a

chore: move doip-server into Cargo workspace to resolve merge conflict

ceb170d

fix(review): address review comments

b98ff03

- structured tracing logging; error! for parse failures - rename DoipResult → Result - single RwLock<SessionManagerInner> + AtomicU64 - merge DiagnosticAck + AckResult; remove AckCode - doc comments on all public API items

fix(review): address .toml config, empty data validation.

dfe3c85

fix(review): add unit tests, trace logging

6d8eab2

fix(review): revert CI SHAs, use constants in vehicle_id, fix doc and…

eff3242

… toml

fix(review): address review comments

1eb7c2b

VinaykumarRS1995 force-pushed the doip-server-initial branch from af05179 to 1eb7c2b Compare April 27, 2026 04:15

arvindr19 approved these changes Apr 27, 2026

View reviewed changes

VinaykumarRS1995 requested a review from stmuench April 27, 2026 15:52

bharatGoswami8 reviewed May 8, 2026

View reviewed changes

bharatGoswami8 suggested changes May 8, 2026

View reviewed changes

bharatGoswami8 suggested changes May 11, 2026

View reviewed changes

rpreddyhv suggested changes May 12, 2026

View reviewed changes

docs: rename diagrams, refactor sequence diagram, add rendered SVGs

e1039b4

bharatGoswami8 suggested changes May 13, 2026

View reviewed changes

VinaykumarRS1995 force-pushed the doip-server-initial branch from 9dca27f to 53214b3 Compare May 19, 2026 11:49

arvindr19 reviewed May 20, 2026

View reviewed changes

		@@ -38,6 +42,9 @@ impl DoipSerializable for Request {
		/// nothing is written to the buffer by design.

Conversation

VinaykumarRS1995 commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

arvindr19 commented Feb 26, 2026

Uh oh!

VinaykumarRS1995 commented Feb 26, 2026

Uh oh!

Uh oh!

arvindr19 commented Feb 26, 2026

Uh oh!

arvindr19 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darkwisebear left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arvindr19 commented Mar 2, 2026

Uh oh!

lh-sag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexmohr commented Mar 4, 2026

Uh oh!

floroks commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stmuench commented Mar 6, 2026

Uh oh!

VinaykumarRS1995 commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VinaykumarRS1995 Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lh-sag commented Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arvindr19 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

VinaykumarRS1995 commented Feb 25, 2026 •

edited

Loading

floroks commented Mar 5, 2026 •

edited

Loading

VinaykumarRS1995 Mar 13, 2026 •

edited

Loading