Skip to content

Add more linter#786

Closed
PierreF wants to merge 4 commits into
masterfrom
add-more-linter
Closed

Add more linter#786
PierreF wants to merge 4 commits into
masterfrom
add-more-linter

Conversation

@PierreF
Copy link
Copy Markdown
Contributor

@PierreF PierreF commented Jan 1, 2024

Add black, codespell and mypy.

mypy is only partially added, mostly to client.py.

Copy link
Copy Markdown
Contributor

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline comments, I'd urge you to separate this into multiple PRs, not a single unreviewable "add more linter" one. I'm happy to review smaller PRs!

Comment thread .pre-commit-config.yaml
Comment thread .pre-commit-config.yaml
Comment thread src/paho/mqtt/client.py
@akx
Copy link
Copy Markdown
Contributor

akx commented Jan 3, 2024

@PierreF Note that an overarching auto-formatting PR like this will make practically every single other open PR unmergeable and nearly impossible to rebase too. Please consider merging or closing them as suitable before an auto-formatting PR (and an auto-formatting PR should only include auto-formatting).

@PierreF
Copy link
Copy Markdown
Contributor Author

PierreF commented Jan 3, 2024

@akx thank for your feedback.

I've splitted the PR in multiple PRs:

Closing this PR in favor of other one.

@PierreF PierreF closed this Jan 3, 2024
@akx
Copy link
Copy Markdown
Contributor

akx commented Jan 3, 2024

@PierreF Thank you, and sorry if my comments sounded a bit harsh – I've just seen the maintenance pain of big PRs like this just steamrolled through 😅

@PierreF PierreF deleted the add-more-linter branch January 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants