Skip to content

Add ALPN support#790

Merged
PierreF merged 2 commits into
eclipse-paho:masterfrom
akx:alpn-2
Jan 13, 2024
Merged

Add ALPN support#790
PierreF merged 2 commits into
eclipse-paho:masterfrom
akx:alpn-2

Conversation

@akx
Copy link
Copy Markdown
Contributor

@akx akx commented Jan 3, 2024

Closes #648 (reworks it to adhere to the new test system).

Also simplifies the SSL/server test fixtures a bit for great happiness.

@PierreF
Copy link
Copy Markdown
Contributor

PierreF commented Jan 3, 2024

Thank, but I've an issue regarding Eclipse requirement with this PR: since some change are authored by @michaelboulton which don't seems to have signed the ECA (https://accounts.eclipse.org/user/eca) I'm not sure I'm allowed to merge it.

@michaelboulton could you complet the ECA signing ? https://accounts.eclipse.org/user/eca

@akx
Copy link
Copy Markdown
Contributor Author

akx commented Jan 10, 2024

@PierreF Hm, well, I signed-off on this (with a Co-authored-by credit for @michaelboulton for the lines and spirit that remain of his original implementation). I don't know what the by-the-book way here is.

@akx
Copy link
Copy Markdown
Contributor Author

akx commented Jan 11, 2024

Rebased post #791.

Co-authored-by: Michael Boulton <michaelboulton@gmail.com>
Signed-off-by: Aarni Koskela <akx@iki.fi>
@PierreF
Copy link
Copy Markdown
Contributor

PierreF commented Jan 13, 2024

Since the change is rather small, I think it's okay to merge it even if first author didn't fully complete the ECA.

@PierreF PierreF merged commit 2ba26d1 into eclipse-paho:master Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants