Fix: Update name-relative fields even when project name is empty#2348
Open
vlakn wants to merge 1 commit into
Open
Fix: Update name-relative fields even when project name is empty#2348vlakn wants to merge 1 commit into
vlakn wants to merge 1 commit into
Conversation
r-mennig
approved these changes
May 29, 2026
| @Before | ||
| public void setUp() { | ||
| fDisplay = Display.getDefault(); | ||
| fDisplay.syncExec(() -> fShell = new Shell(fDisplay)); |
Contributor
There was a problem hiding this comment.
Calling Display.syncExec() here and further below shouldn't be necessary since the test is already running in the UI thread.
Author
There was a problem hiding this comment.
Thank you for your review! I removed the unnecessary Display.syncExec() calls.
vlakn
force-pushed
the
fix_name_modify_listener_of_feature_spec_page
branch
2 times, most recently
from
eee162d to
f2633eb
Compare
vlakn
force-pushed
the
fix_name_modify_listener_of_feature_spec_page
branch
from
f2633eb to
6670661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the project name field was left empty (or otherwise invalid), the feature name and version fields were not being updated automatically. This broke the "auto-fill" behaviour that derives name-relative field values from the project name during the initial wizard state.
Fix
Moved the
updateNameRelativeFields()call to before the early-return guard, so that name-relative fields are always refreshed whenfUpdateNameis true, regardless of whether the rest of the page is currently valid.