Add Select Required and Remove Unresolved actions to validation dialog#2351
Open
vogella wants to merge 1 commit into
Open
Add Select Required and Remove Unresolved actions to validation dialog#2351vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
The plug-in validation dialog (shown by the "Validate Plug-ins" button on the launch configuration's Plug-ins/Bundles tab) now offers two in-place fixes for the reported problems: * Select Required adds the missing required plug-ins/features. * Remove Unresolved unchecks every plug-in whose bundle did not resolve, matched by symbolic name and version. Validation is repeated against the new checked set after each pass, so plug-ins that only become unresolved once a dependency has been removed are handled in the same click. Both actions validate the tree's current (unsaved) selection rather than the persisted launch configuration, so the dialog refreshes to reflect the change, and the tab is marked dirty so the change can be applied. The dialog clears to a "no problems" entry once all issues are fixed. The buttons are opt-in via PluginStatusDialog.setActions(), so the dialog shown at launch time (where there is no plug-in tree to modify) is unaffected. Remove Unresolved is offered only for plug-in/bundle launches, not for feature-based launches. Fixes eclipse-pde#2323
vogella
force-pushed
the
remove-unresolved-plugins-button
branch
from
abf0ec5 to
aa47988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plug-in validation dialog (opened by the Validate Plug-ins button on a launch configuration's Plug-ins/Bundles tab) now offers two in-place fixes. Select Required adds the missing required plug-ins, and Remove Unresolved unchecks every plug-in whose bundle did not resolve, repeating validation so transitively broken plug-ins are handled in one click. This removes the manual cleanup the issue describes, since you can fix the selection directly from the list that reports the problems.
Both actions validate the tree's current selection (not the persisted configuration) so the dialog refreshes to reflect the change, and the tab is marked dirty so it can be applied. The buttons are opt-in, so the dialog shown at launch time, where there is no tree to modify, is unaffected; Remove Unresolved is offered only for plug-in/bundle launches, not feature-based ones.
Fixes #2323