Skip to content

Compute foreground and background colours for setEnabled and setEditable in StyledText #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elsazac merged 1 commit into from
Apr 8, 2026
+48 −30
Merged

Compute foreground and background colours for setEnabled and setEditable in StyledText #3154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 45 additions & 27 deletions .../org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2021 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -149,7 +149,7 @@ public class StyledText extends Canvas {
/** False iff the widget is disabled */
boolean enabled = true;
/** True iff the widget is in the midst of being enabled or disabled */
boolean insideSetEnableCall;
boolean insideUpdateColorsCall;
Clipboard clipboard;
int clickCount;
int autoScrollDirection = SWT.NULL; // the direction of autoscrolling (up, down, right, left)
Expand Down Expand Up @@ -8278,7 +8278,7 @@ public void setBackground(Color color) {
boolean backgroundDisabled = false;
if (!this.enabled && color == null) {
if (background != null) {
Color disabledBg = getDisplay().getSystemColor(SWT.COLOR_TEXT_DISABLED_BACKGROUND);
Color disabledBg = getDisplay().getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND);
if (background.equals(disabledBg)) {
return;
} else {
Expand All @@ -8287,11 +8287,13 @@ public void setBackground(Color color) {
}
}
}
customBackground = color != null && !this.insideSetEnableCall && !backgroundDisabled;
customBackground = color != null && !this.insideUpdateColorsCall && !backgroundDisabled;
background = color;
super.setBackground(color);
resetCache(0, content.getLineCount());
setCaretLocations();
if (content != null) {
resetCache(0, content.getLineCount());
setCaretLocations();
}
super.redraw();
}
/**
Expand Down Expand Up @@ -8772,6 +8774,35 @@ public void setDragDetect (boolean dragDetect) {
checkWidget ();
this.dragDetect = dragDetect;
}

/**
* Applies foreground and background colors based on the control's state.
* Custom foreground and background settings are preserved and not overridden.
*
* @param enabled {@code true} if the control is enabled; {@code false} otherwise
* @param editable {@code true} if the control is editable; {@code false} otherwise
*
*/
private void updateColors(boolean enabled, boolean editable) {
this.insideUpdateColorsCall = true;
Display display = getDisplay();
try {
if (enabled && editable) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_LIST_BACKGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_LIST_FOREGROUND));
} else if(!enabled) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_DARK_GRAY));
} else if(!editable) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_LIST_FOREGROUND));
}
}
finally {
this.insideUpdateColorsCall = false;
}
}

/**
* Sets whether the widget content can be edited.
*
Expand All @@ -8785,28 +8816,13 @@ public void setDragDetect (boolean dragDetect) {
public void setEditable(boolean editable) {
checkWidget();
this.editable = editable;
updateColors(this.enabled, this.editable);
}
@Override
public void setEnabled(boolean enabled) {
super.setEnabled(enabled);
Display display = getDisplay();
this.enabled = enabled;
this.insideSetEnableCall = true;
try {
if (enabled && editable) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_LIST_BACKGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_LIST_FOREGROUND));
} else if(!enabled) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_TEXT_DISABLED_BACKGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND));
} else if(!editable) {
if (!customBackground) setBackground(display.getSystemColor(SWT.COLOR_TEXT_DISABLED_BACKGROUND));
if (!customForeground) setForeground(display.getSystemColor(SWT.COLOR_LIST_FOREGROUND));
}
}
finally {
this.insideSetEnableCall = false;
}
updateColors(this.enabled, this.editable);
}
Comment thread
elsazac marked this conversation as resolved.

@Override
Expand Down Expand Up @@ -8873,7 +8889,7 @@ public void setForeground(Color color) {
boolean foregroundDisabled = false;
if (!this.enabled && color == null) {
if (foreground != null) {
Color disabledFg = getDisplay().getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND);
Color disabledFg = getDisplay().getSystemColor(SWT.COLOR_DARK_GRAY);
if (foreground.equals(disabledFg)) {
return;
} else {
Expand All @@ -8882,11 +8898,13 @@ public void setForeground(Color color) {
}
}
}
customForeground = color != null && !this.insideSetEnableCall && !foregroundDisabled;
customForeground = color != null && !this.insideUpdateColorsCall && !foregroundDisabled;
foreground = color;
super.setForeground(color);
resetCache(0, content.getLineCount());
setCaretLocations();
if (content != null) {
resetCache(0, content.getLineCount());
setCaretLocations();
}
super.redraw();
}
/**
Expand Down
6 changes: 3 additions & 3 deletions ...tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -3245,8 +3245,8 @@ public void test_setDoubleClickEnabledZ(){
@Test
public void test_setEnabled(){
// Get colors
Color disabledBg = text.getDisplay().getSystemColor(SWT.COLOR_TEXT_DISABLED_BACKGROUND);
Color disabledFg = text.getDisplay().getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND);
Color disabledBg = text.getDisplay().getSystemColor(SWT.COLOR_WIDGET_DISABLED_FOREGROUND);
Color disabledFg = text.getDisplay().getSystemColor(SWT.COLOR_DARK_GRAY);
Color enabledBg = text.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND);
Color enabledFg = text.getDisplay().getSystemColor(SWT.COLOR_LIST_FOREGROUND);

Expand Down
Loading