Skip to content

Avoid BusyIndicator putting Display to sleep after being done #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Apr 9, 2026
Merged

Avoid BusyIndicator putting Display to sleep after being done #3181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...g.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/BusyIndicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ public class BusyIndicator {
static final String BUSYID_NAME = "SWT BusyIndicator"; //$NON-NLS-1$
static final String BUSY_CURSOR = "SWT BusyIndicator Cursor"; //$NON-NLS-1$

private static final Runnable DO_NOTHING = () -> {};

/**
* Runs the given <code>Runnable</code> while providing
* busy feedback using this busy indicator.
Expand Down Expand Up @@ -111,10 +113,14 @@ public static void showWhile(Future<?> future) {
stage.handle((nil1, nil2) -> {
if (!display.isDisposed()) {
try {
display.wake();
// Use asyncExec() to wake up the display thread instead of wake()
// as this call may happen between the future.isDone() check and the
// display.sleep() call such that a wake() may get lost whereas an asyncExec()
// will wake up the sleep() even if it is scheduled before calling sleep()
display.asyncExec(DO_NOTHING);
} catch (SWTException e) {
// ignore then, this can happen due to the async nature between our check for
// disposed and the actual call to wake the display can be disposed
// ignore; due to the async nature between our disposed check and scheduling
// asyncExec(), the display may already be disposed
}
}
return null;
Expand Down
Loading