Implement Cross-Platform Dark Theme Preferred API in SWT#3184
Merged
vogella merged 2 commits intoeclipse-platform:masterfrom Apr 8, 2026
Merged
Implement Cross-Platform Dark Theme Preferred API in SWT#3184vogella merged 2 commits intoeclipse-platform:masterfrom
vogella merged 2 commits intoeclipse-platform:masterfrom
Conversation
Contributor
vogella
force-pushed
the
swt-dark-theme-api
branch
2 times, most recently
from
8b7cb5b to
321386d
Compare
Contributor
Author
|
The warning is about the version filter at lines 246-252. Since the PR adds new APIs (dark theme), the version bump to 3.134.0 is now justified, making the filter unnecessary. |
The filter suppressing the minor version bump warning is no longer needed since new APIs have been added in this release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vogella
force-pushed
the
swt-dark-theme-api
branch
from
eb81791 to
8cdfebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Cross-Platform Dark Theme Preferred API in SWT. Will is currently handled in platform.ui and having such an API will make platform.ui easier and allows us to simplify the styling (and remove reflection access)