[Gtk4] Overhaul Shell sizing#3358
Merged
Merged
Conversation
Non-resizable shells (e.g. DIALOG_TRIM) appear too tall when setSize(computeSize()) is called before open() because window decoration heights were not correctly accounted for with GTK4 CSD. Maximized shells had their content cut off at the bottom because the shell content was not resized to fill the full maximized area. Use the layout signal, which fires after the the new dimensions are set, to correctly resize the shell content to fill the maximized window.
Member
Author
|
Full screen eclipse: About dialog (note the white space under the eclipse logo image due do dialog height miscalculation): |
Member
Author
|
Fixes #3333 too: |
Contributor
jonahgraham
approved these changes
Jun 3, 2026
Contributor
This fixes full screen in a way I didn't expect. It now accounts for the dimensions of my bottom panel in KDE. |
Member
Author
|
Would you please attach a screenshot? Was full screen working for you before this PR and is now broken or now it's broken in different way? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-resizable shells (e.g. DIALOG_TRIM) appear too tall when setSize(computeSize()) is called before open() because window decoration heights were not correctly accounted for with GTK4 CSD.
Maximized shells had their content cut off at the bottom because the shell content was not resized to fill the full maximized area. Use the layout signal, which fires after the the new dimensions are set, to correctly resize the shell content to fill the maximized window.