Skip to content

Allow user to set default theme#3854

Merged
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:default-theme-setting-by-user
Apr 7, 2026
Merged

Allow user to set default theme#3854
vogella merged 1 commit intoeclipse-platform:masterfrom
vogella:default-theme-setting-by-user

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Apr 2, 2026

During theme switch the user can now set the selected theme as default This setting is saved as configuration scope and loaded for new workspaces unless the user has a theme set for this specific workspace. Add 'Use as default theme' checkbox to theme
restart dialog

@vogella vogella marked this pull request as draft April 2, 2026 10:08
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 2, 2026

Configuration scope is hard to test with runtime Eclipse, as each runtime Eclipse uses its own "configuration scope". So to test this change, you have to build the IDE with the new bundles and start this new instance.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Test Results

   852 files  ±0     852 suites  ±0   54m 48s ⏱️ - 1m 38s
 7 894 tests ±0   7 651 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 184 runs  ±0  19 529 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit 75599e0. ± Comparison against base commit efb185f.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the default-theme-setting-by-user branch from bc1a650 to bff29fd Compare April 2, 2026 12:14
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 2, 2026

To test, I needed to build the aggregator. Start Eclipse switch theme and select: use as default in the popup:

1.) Start Eclipse and change Theme

image

Now new workspaces or workspaces without configured theme will use the new default. Workspaces which have an explicit theme set will not be affected

@vogella vogella marked this pull request as ready for review April 2, 2026 13:01
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 2, 2026

Plan to merge early M2, to late for M1.

@vogella vogella force-pushed the default-theme-setting-by-user branch 3 times, most recently from 9a46294 to c9bd81a Compare April 7, 2026 05:55
During theme switch the user can now set the selected theme as default.
This setting is saved as configuration scope and loaded for new
workspaces unless the user has a theme set for this specific workspace.
Adds 'Use as default theme' checkbox to the theme restart dialog.
@vogella vogella force-pushed the default-theme-setting-by-user branch from c9bd81a to 75599e0 Compare April 7, 2026 06:59
@vogella vogella merged commit a7e91a0 into eclipse-platform:master Apr 7, 2026
18 checks passed
@vogella vogella deleted the default-theme-setting-by-user branch April 7, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant