Remove dead andFilters concept from Problems view filter#3861
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 8, 2026
Merged
Remove dead andFilters concept from Problems view filter#3861vogella merged 1 commit intoeclipse-platform:masterfrom
vogella merged 1 commit intoeclipse-platform:masterfrom
Conversation
The andFilters boolean was always hardcoded to false with no UI to change it. This removes the dead AND-filter logic that was never reachable: - Remove andFilters field, getter, and setter from FiltersConfigurationDialog and MarkerContentGenerator - Remove TAG_AND persistence (read/write) from MarkerContentGenerator - Simplify select() method to always use OR logic (the only active path) - Remove unused getResourcesFiltersAnded() from MarkerResourceUtil - Simplify computeResources() to always use OR resource computation - Update ExtendedMarkersView.openFiltersDialog() call signature - Update MarkerSupportViewTest reflection calls to match new signature - Clean up Javadoc referencing AND filter behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
andFiltersboolean inFiltersConfigurationDialogwas always hardcoded tofalse— no UI control ever set it totrue. This removes the dead AND-filter logic that was never reachable.Changes
andFiltersfield, getter, and setter fromFiltersConfigurationDialogandMarkerContentGeneratorTAG_ANDpersistence (read/write) fromMarkerContentGeneratorselect()method to always use OR logic (the only active code path)getResourcesFiltersAnded()fromMarkerResourceUtilcomputeResources()to always use OR resource computationExtendedMarkersView.openFiltersDialog()call signatureMarkerSupportViewTestreflection calls to match new signaturesTesting
mvn clean compile -pl :org.eclipse.ui.ide -Pbuild-individual-bundlesandFilterswas alwaysfalse, this is a pure dead-code removal with no behavioral change