Skip to content

Introduce AbstractInlinedAnnotation#getMinings() to expose ICodeMining list#3867

Merged
tobiasmelcher merged 1 commit intoeclipse-platform:masterfrom
tobiasmelcher:AbstractInlinedAnnotation_getMinings
Apr 8, 2026
Merged

Introduce AbstractInlinedAnnotation#getMinings() to expose ICodeMining list#3867
tobiasmelcher merged 1 commit intoeclipse-platform:masterfrom
tobiasmelcher:AbstractInlinedAnnotation_getMinings

Conversation

@tobiasmelcher
Copy link
Copy Markdown
Contributor

Adds a new public API method getMinings() to AbstractInlinedAnnotation that provides read-only access to the list of ICodeMining instances associated with an inlined annotation.

This API is needed to implement the unified diff feature via eclipse-platform/eclipse.platform#2560

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Test Results

   852 files  ±0     852 suites  ±0   57m 13s ⏱️ - 6m 33s
 7 894 tests ±0   7 651 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 184 runs  ±0  19 529 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit eb554cf. ± Comparison against base commit a7e91a0.

♻️ This comment has been updated with latest results.

@tobiasmelcher tobiasmelcher force-pushed the AbstractInlinedAnnotation_getMinings branch from 378a851 to 1093ee7 Compare April 6, 2026 09:40
list

Adds a new public API method `getMinings()` to
`AbstractInlinedAnnotation` that provides read-only access to the list
of `ICodeMining` instances associated with an inlined annotation.

This API is needed to implement the unified diff feature via
eclipse-platform/eclipse.platform#2560
@tobiasmelcher tobiasmelcher force-pushed the AbstractInlinedAnnotation_getMinings branch from 1093ee7 to eb554cf Compare April 7, 2026 15:59
@vogella
Copy link
Copy Markdown
Contributor

vogella commented Apr 8, 2026

LGTM

@mickaelistria
Copy link
Copy Markdown
Contributor

Looks good to me as well.

@tobiasmelcher tobiasmelcher merged commit 6e6bbbf into eclipse-platform:master Apr 8, 2026
21 of 22 checks passed
@BeckerWdf BeckerWdf added this to the 4.40 M2 milestone Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants