Fix disabled wizard buttons appearing enabled in dark theme#3870
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Fix disabled wizard buttons appearing enabled in dark theme#3870vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Author
|
New 
Old 
|
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
vogella
force-pushed
the
fix/dark-theme-disabled-wizard-buttons
branch
from
3c17f6b to
c7c8bb4
Compare
Contributor
vogella
force-pushed
the
fix/dark-theme-disabled-wizard-buttons
branch
from
c7c8bb4 to
bebec37
Compare
vogella
force-pushed
the
fix/dark-theme-disabled-wizard-buttons
branch
from
bebec37 to
3d92220
Compare
In the dark theme, the CSS sets a foreground color on all Button elements, which overrides the native OS disabled button rendering. This causes disabled buttons (like 'Finish') to look identical to enabled ones. Fix this by setting a 'disabled' CSS class on wizard buttons when they are disabled. The dark theme CSS now includes a Button.disabled rule with a dimmed foreground color. A reskin is triggered on state change so the CSS engine re-applies styles without needing the global dynamic CSS pseudo-class support (which is disabled for performance).
vogella
force-pushed
the
fix/dark-theme-disabled-wizard-buttons
branch
from
3d92220 to
0273e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the dark theme, the CSS sets a foreground color on all Button elements, which overrides the native OS disabled button rendering. This causes disabled buttons (like 'Finish') to look identical to enabled ones.
Approach
Sets a
disabledCSS class on wizard buttons when they are disabled viasetData("org.eclipse.e4.ui.css.CssClassName", "disabled"). The dark theme CSS includes a newButton.disabledrule with a dimmed foreground color. Areskin(SWT.NONE)call triggers the CSS engine to re-apply styles.This avoids enabling global dynamic CSS pseudo-class support (
org.eclipse.e4.ui.css.dynamic), which is disabled for performance reasons.Changes
WizardDialog.java: AddedsetButtonEnabled()helper used in all button state change paths (updateButtons,saveEnableStateAndSet,restoreEnableState)e4-dark_globalstyle.css: AddedButton.disabled { color: #777777; }rule