Skip to content

Defer expensive project reference computation during selection changes #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 2 commits into from
Apr 8, 2026
+20 −0
Merged

Defer expensive project reference computation during selection changes #3871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ad8d3
Defer expensive project reference computation during selection changes
vogella Apr 6, 2026
8c4d499
Fix Javadoc warning: use @code instead of @link for private method
vogella Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...es/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/CloseUnrelatedProjectsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.eclipse.jface.dialogs.IDialogConstants;
import org.eclipse.jface.dialogs.MessageDialogWithToggle;
import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.window.IShellProvider;
import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.widgets.Shell;
Expand Down Expand Up @@ -130,6 +131,25 @@ public CloseUnrelatedProjectsAction(IShellProvider provider){
initAction();
}

/**
* Overrides to avoid calling the expensive
* {@code computeRelated(List)} during selection changes. Uses only
* the raw selection to determine enablement.
*/
@Override
protected boolean updateSelection(IStructuredSelection s) {
selectionDirty = true;
if (!selectionIsOfType(IResource.PROJECT)) {
return false;
}
for (IResource resource : super.getSelectedResources()) {
if (resource instanceof IProject project && project.isOpen()) {
return true;
}
}
return false;
}

@Override
public void run() {
if (promptForConfirmation()) {
Expand Down
Loading