Add workspace import support to Eclipse launcher window#3995
Conversation
5d4e732 to
56de0b8
Compare
|
What about storing the workspaces in user scope scoped by product / application instead of storing them in configuration scope. This way the workspaces for a product would always be the same which I think is the most common use case. |
Test Results 861 files ±0 861 suites ±0 52m 29s ⏱️ -1s For more details on these failures, see this check. Results for commit a0e1cf5. ± Comparison against base commit 7ec52db. ♻️ This comment has been updated with latest results. |
|
Interesting idea, but can we please made this feature optional, so the "Import..." is not shown at all (we extend We have Eclipse based application deployed with rpm, so by default installation is read only and all settings are stored on (typically mounted) user home and for a specific application version the path would be something like Not only that this path is by default hidden, it is also application version specific, different application versions are installed in parallel and should not share the workspaces used. "Import..." would casue more troubles in this scenario, so we would want to disable this completely to avoid user errors.
In our case it would be important to have that "per product / per version" or give a chance to see that the workspace is for a different product version. Ideally Eclise could automatically detect Eclipse workspaces from "compatible" workspaces. "Compatible" is the key, and it should be possible, similar to |
56de0b8 to
979ee98
Compare
Thanks for the feedback, i am exploring this path. If it can be done in user mode, made it optional. |
979ee98 to
cbeb03c
Compare
cbeb03c to
29c6d94
Compare
loggers(DO NOT DELETE)
|
See https://github.com/eclipse-platform/eclipse.platform.ui/pull/3875/changes how to use user scope to save the recent workspaces together with a product / application prefix. The example is used for the theme but it should be easy to apply the same approach to the workspaces. |
Thanks aton, i was about to ask for some help in this context. Let me check on that. |
|
Why are there 3 commits? |
@merks : Thanks for your interest. |
| if (Platform.getInstanceLocation().isSet()) { | ||
| store.setValue(RECENT_WORKSPACES, sb.toString()); | ||
| } | ||
| // else { |
There was a problem hiding this comment.
I guess you will clean this up.
There was a problem hiding this comment.
Will need to investigate on this if configuration scope needs any check here or else can be removed.
| protected Control createDialogArea(Composite parent) { | ||
| Composite container = (Composite) super.createDialogArea(parent); | ||
| container.setLayout(new GridLayout(1, false)); | ||
| // FIX ORDER |
There was a problem hiding this comment.
Sorry that was a debug message while coding, removed now.
any workspaces or has already imported workspaces, add javadoc, update removeWorkspaceFromLauncher().
29c6d94 to
a0e1cf5
Compare
|
I assume if you switch to save and load the recent workspaces from User Scope no import is needed. |
May be, let me check. Still trying to figure out. |
|
It's quite a bit of extra logic for what to me seems a narrow use case. I think Lar's question kind of hints at the fact that one might share them across all products of the same type. That being said, given I have 50 installations and I never want to share workspaces across them, so I don't actually like that so much. But maybe I'm special. Then again, one can always find workspace without an import dialog too, so I'm a bit ambivalent over all... |
|
I feel UserScope + Product ID is best generic solution like updated in #3878. Please let me know if we can go with this. |
Sounds good to me. |
|
How is RECENT_WORKSPACES value maintained with multiple products are using this? Is there some kind of locking to prevent overwriting the values stored from other instances. Is this value ordered and how do multiple instance working with a single such list impact the order across the instances? |
This PR introduces workspace capability in the Choose Workspace dialog.
Users can now import recent workspaces from a previous Eclipse installation directly from the launcher UI.
Features added:
Additional improvements:
This change enhances workspace migration usability and improves the overall launcher experience for users moving between Eclipse installations.
Before this pr :

After this pr :
Import...is the newly added button ->Import..., you can browse previous eclipse installation path and browse recently used workspaces in it and import them like this - the desired ones ->Import...again like this ->How to test this pr :
step 1 - pick this jar ->
org.eclipse.ui.ide_3.23.100.v20260511-1219.zip
extract this zip file to get a jar, place this jar in the fresh eclipse installation at
..\eclipse\pluginsfolder.step 2 - Open this file "..\eclipse\configuration\org.eclipse.equinox.simpleconfigurator\bundles.info", search for "org.eclipse.ui.ide," line and replace the whole line with
org.eclipse.ui.ide,3.23.100.v20260511-1219,plugins/org.eclipse.ui.ide_3.23.100.v20260511-1219.jar,4,falseNote : Once done with testing, please revert back to get the original eclipse installation state before you proceed.
I am not sure if this can be tested in a different way easily, but i have tested this way on windows platform.