Use TestExecutionListener to log test start and end in org.eclipse.ui.tests#4034
Use TestExecutionListener to log test start and end in org.eclipse.ui.tests#4034trancexpress wants to merge 1 commit into
Conversation
Test Results 861 files ±0 861 suites ±0 57m 12s ⏱️ + 4m 44s For more details on these failures, see this check. Results for commit f1b1a43. ± Comparison against base commit 7ec52db. ♻️ This comment has been updated with latest results. |
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change looks good to get the logging of execution orders for JUnit 5 UI tests again. I just don't think we should move the JUnit 4 rules until those tests have been migrated to JUnit 5.
Sure, that makes things even more simple. If we do see duplicated logged starts/ends in the first I-build with the changes, we can check where and why. |
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
I just noted that the log outputs for the JUnit 4 tests are not missing anymore, but the outputs for the JUnit 5 tests are not present either. This seems to be caused by the org.junit.platform.launcher import being required by the actual test bundle ( org.eclipse.tests.ui) as well. Adding that package import to the test bundle leads to proper log output.
And then actually logging is also done for the JUnit 4 tests executed by the vintage engine, so your initial changes to remove the rules for those test swere actually correct. The issue was just that no logging by the TestExecutionListener was done at all.
trancexpress
force-pushed
the
gh4032
branch
5 times, most recently
from
80b77bf to
cc66009
Compare
|
Anything else from your side @HeikoKlare ? If not I'll merge this. |
|
Is it working as expected now? I would have expected some But in the Jenkins and GHA logs for this PR, I do not find anything like that. |
The start and end messages are logged in the workspace log, not printed to command line. I guess we can do both, if you require this, but the entries in the workspace log are the most useful for me. Its easy to tell what logged errors occurred during which test, which tracing belongs to which test and so on. |
|
I see. For me it's fine to not have verbose output to the command line for this. Do we have access to the workspace logs for GHA and Jenkins executions in PRs? I did not find those logs yet. |
I don't know where the logs are for GH jobs. I check the I-build ones (e.g. https://download.eclipse.org/eclipse/downloads/drops4/I20260531-1800/testresults/logs.html), if the starts and ends are missing in the first I-build with the change here, I'll check what is going wrong. |
trancexpress
force-pushed
the
gh4032
branch
2 times, most recently
from
19731be to
784a204
Compare
|
Anything else here @HeikoKlare ? |
|
Merging this in a few hours if there are no objections. |
….tests Add a JUnit Jupiter TestExecutionListener to org.eclipse.ui.tests, which logs test start and end events via UIPlugin. The listener is defined in org.eclipse.ui.tests.harness, so that it can be reused by other test bundles. Additionally, usage of TestRunLogUtil.LOG_TESTRUN rule is removed, since the new listener covers the rule functionality. Fixes: eclipse-platform#4032
|
The fails are #4056, I'll wait for that to get fixed, just in case. |
2 participants
Add a JUnit Jupiter
TestExecutionListenertoorg.eclipse.ui.tests, which logs test start and end events viaUIPlugin.The listener is defined in
org.eclipse.ui.tests.harness, so that it can be reused by other test bundles.Fixes: #4032