Trigger Show In for typed selection in Open Resource dialog#4057
Open
vogella wants to merge 1 commit into
Open
Trigger Show In for typed selection in Open Resource dialog#4057vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
The Show In action for a non-file resource was gated on the OK button's enabled state. When the resource was reached by typing a pattern rather than clicking the row, that state could lag behind the auto-selected first match, so Enter and the Open button did nothing. Act on the selected item directly, the same way the dialog opens a typed file, so a first-matched project triggers Show In via Enter or Open too.
Contributor
Test Results 861 files ±0 861 suites ±0 55m 8s ⏱️ + 2m 40s For more details on these failures, see this check. Results for commit 2cd8dfb. ± Comparison against base commit 7ec52db. |
Contributor
Author
|
Test failure related to eclipse-platform/eclipse.platform#2700 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Open Resource dialog, the Show In action for a non-file resource (for example a project) was gated on the OK button's enabled state. When the resource was reached by typing a pattern instead of clicking the row, that enabled state could lag behind the auto-selected first match, so pressing Enter or the Open button did nothing.
This acts on the selected item directly, the same way the dialog opens a typed file. A first-matched project now triggers Show In via Enter or the Open button, making the keyboard and mouse paths behave consistently.