Simplify intro framework: deprecate StandbyPart and IntroLaunchBar#2610
Simplify intro framework: deprecate StandbyPart and IntroLaunchBar#2610vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Treat the welcome screen like a regular editor by removing the special standby mode and launch bar handling from CustomizableIntroPart. Changes: - Simplify CustomizableIntroPart: remove StackLayout, StandbyPart handling, and standby memento logic. Use FillLayout to show the presentation directly. - Deprecate IntroLaunchBar (forRemoval=true): the toolbar launch bar is no longer created when the intro is minimized. - Deprecate StandbyPart (forRemoval=true): standby content parts are no longer used by the intro framework. - Clean up IntroURL: deprecate SET_STANDBY_MODE, SHOW_STANDBY, and SWITCH_TO_LAUNCH_BAR actions. The switchToLaunchBar and handleStandbyState methods are removed; deprecated actions now log warnings and fall back to showing/closing the intro. - Deprecate closeLaunchBar() and setLaunchBar() in IntroPlugin. - Remove <launchBar> element from universal intro plugin.xml. - Bump org.eclipse.ui.intro version to 3.9.0. Fixes eclipse-platform#2598 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Was there an issue in which I expressed my reservation about the welcome page changes you proposed? Is this part of that? |
Test Results 54 files ±0 54 suites ±0 51m 18s ⏱️ + 15m 25s For more details on these failures and errors, see this check. Results for commit b763f32. ± Comparison against base commit 9c3aad6. |
Sorry, not sure what you are asking? This is draft pr to see if my suggestion is feasible. If concerns are continued to remain raised and not resolved this change will be dropped. |
|
As I mentioned in the issue just now, it's really a challenge to keep up with the floods of emails. I can only hope this is determined not to be feasible and is dropped. |
2 participants
Summary
Treat the welcome screen like a regular editor by removing the special standby mode and launch bar handling from
CustomizableIntroPart.Changes
CustomizableIntroPart: RemoveStackLayout,StandbyParthandling, and standby memento logic. UseFillLayoutto show the presentation directly.IntroLaunchBar(forRemoval=true): The toolbar launch bar is no longer created when the intro is minimized.StandbyPart(forRemoval=true): Standby content parts are no longer used by the intro framework.IntroURL: DeprecateSET_STANDBY_MODE,SHOW_STANDBY, andSWITCH_TO_LAUNCH_BARactions. RemoveswitchToLaunchBar()andhandleStandbyState()methods; deprecated actions now log warnings and fall back to showing/closing the intro.closeLaunchBar()andsetLaunchBar()inIntroPlugin.<launchBar>element from universal introplugin.xml.org.eclipse.ui.introversion to 3.9.0.Testing
org.eclipse.ui.introcompiles with 0 errors and no new warnings.Fixes #2598