Skip to content

Clean Code for ant/org.eclipse.ant.ui#2684

Open
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/ant/org.eclipse.ant.ui
Open

Clean Code for ant/org.eclipse.ant.ui#2684
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/ant/org.eclipse.ant.ui

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Jun 2, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 59c25da4701824d9e2e2aef9f76604f2e8a29d06 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 3 Jun 2026 03:40:07 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
index f5be01ca45..d63a6e7b84 100644
--- a/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
+++ b/ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ant.ui; singleton:=true
-Bundle-Version: 3.10.500.qualifier
+Bundle-Version: 3.10.600.qualifier
 Bundle-Activator: org.eclipse.ant.internal.ui.AntUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test Results

    51 files   -   3      51 suites   - 3   30m 36s ⏱️ - 5m 12s
 4 438 tests  - 229   4 416 ✅  - 229   22 💤 ±0  0 ❌ ±0 
11 223 runs   - 672  11 070 ✅  - 672  153 💤 ±0  0 ❌ ±0 

Results for commit 3bff3a0. ± Comparison against base commit a569c2c.

This pull request removes 229 tests.
org.eclipse.ant.tests.ui.APITests ‑ testCompareJavaVersions
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyMisc
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyNoAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsExternalFiles
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsPerformance
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsSimpleHierarchyAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsSimpleHierarchyNoAliases
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetTargetsLaunchConfiguration
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetTargetsLaunchConfigurationMinusD
…

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/ant/org.eclipse.ant.ui branch from 986ec01 to 13cef3c Compare June 3, 2026 03:33
org.eclipse.jface.text;bundle-version="[3.5.0,4.0.0)";resolution:=optional,
org.eclipse.ui.workbench.texteditor;bundle-version="[3.5.0,4.0.0)";resolution:=optional,
org.eclipse.ui.editors;bundle-version="[3.19.0,4.0.0)";resolution:=optional,
org.apache.ant;bundle-version="1.9.4",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I perform the find unused in the IDE then ant is not removed!
So for some reason we have a discrepancy between when executed with Tycho and with PDE directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants